Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auth to use api token and user email #86

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: auth to use api token and user email #86

merged 1 commit into from
Oct 17, 2024

Conversation

pnadolny13
Copy link
Collaborator

No description provided.

@pnadolny13 pnadolny13 marked this pull request as ready for review October 17, 2024 16:18
@pnadolny13 pnadolny13 merged commit ca4fe87 into main Oct 17, 2024
2 of 3 checks passed
@pnadolny13 pnadolny13 deleted the fix_auth branch October 17, 2024 16:18
@ReubenFrankel
Copy link
Contributor

This doesn't work with the current Meltano Hub definition - users are having to define api_token and email settings themselves: https://meltano.slack.com/archives/C069CQNHDNF/p1731772659610249

I assume basic auth change from password to api_token is to do with https://developer.atlassian.com/cloud/jira/platform/basic-auth-for-rest-apis/#get-an-api-token, where it is recommended (required?) to send an API token in place of a password - hence the rename? Possibly similar for username to email.

Why was OAuth access token support removed?

@pnadolny13
Copy link
Collaborator Author

pnadolny13 commented Nov 18, 2024

This doesn't work with the current Meltano Hub definition - users are having to define api_token and email settings themselves

@ReubenFrankel thanks for raising this! We'll have to get the hub definition updated. meltano/hub#1897

I assume basic auth change from password to api_token is to do with...

Yes my understanding is that user/pass is no longer allowed.

Why was OAuth access token support removed?

The original OAuth implementation was incomplete so it was better to remove it until its properly supported. The original implementation only accepted an access token instead of accepting client id/secret to generate and refresh the token. I opened #94 to track adding that back in properly.

@ReubenFrankel
Copy link
Contributor

@pnadolny13 Thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants