[kernel] Experimental heap_free valitity checks #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes! |
ghaerr
reviewed
Nov 23, 2024
tlvc/lib/heap.c
Outdated
|
|
||
| #ifdef HEAPFREE_VALIDATE_2 | ||
| //printk("Heap canary %x\n", *((char *)data - 1)&0xff); | ||
| if ((*((char *)data - 1)&0xff) != HEAP_CANARY) { |
There was a problem hiding this comment.
Can't you just use if (h->canary != HEAP_CANARY) here rather than using complicated pointer arithmetic that also assumes canary is the last struct member?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 'canary' based and 'list' based validity checks for
heap_freefor discussion, re. #105.@ghaerr, to me these two variants do exactly the same, which means the first (list based) alternative is due for deletion. Do you agree?