Fix pod watch namespace for nv-ipam-node #37
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix, nv-ipam-node was watching only for Pods in the namespace provided by
--ippools-namespace
arg. This is incorrect and cause "stale IP cleaner" to work incorrectly.Watch Pods in all namespaces instead.
+ Add extra check to the cleaner to check Pod in the API (in addition to the cache)
before decide to cleanup the stale allocation.