Run migration logic with leader election #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rollandf
commented
Sep 18, 2023
rollandf
commented
- Add Controller Migrator to the Manager
- Add a channel to block reconcile until Migrator finishes
rollandf
force-pushed
the
leader-migrate
branch
from
5aad825 to
c537ac2
Compare
rollandf
force-pushed
the
leader-migrate
branch
from
c537ac2 to
e9fbd30
Compare
ykulazhenkov
previously approved these changes
Sep 19, 2023
ykulazhenkov
dismissed
their stale review
one more comment to address before merging
- Add Controller Migrator to the Manager - Add a channel to block reconcile until Migrator finishes Signed-off-by: Fred Rolland <[email protected]>
rollandf
force-pushed
the
leader-migrate
branch
from
e9fbd30 to
efd152a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.