Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook #16

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Add webhook #16

merged 3 commits into from
Aug 27, 2024

Conversation

adrianchiris
Copy link
Collaborator

No description provided.

Add validation check for Node object existance
on CREATE call.

create webhook in main condtionally via env var

Signed-off-by: adrianc <[email protected]>
add autogenerated code to support webhook deployment
using kustomize.

in addition un-comment cert-manager support

Signed-off-by: adrianc <[email protected]>
- add target to install helm binary
- add script to install dependencies in minikube cluster
- update dev env targets

Signed-off-by: adrianc <[email protected]>
@coveralls
Copy link

coveralls commented Aug 25, 2024

Pull Request Test Coverage Report for Build 10547926922

Details

  • 26 of 42 (61.9%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 65.565%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/maintenance-manager/main.go 0 5 0.0%
internal/webhook/nodemaintenance_webhook.go 26 37 70.27%
Files with Coverage Reduction New Missed Lines %
internal/controller/maintenanceoperatorconfig_controller.go 2 71.88%
Totals Coverage Status
Change from base Build 10511482808: -0.2%
Covered Lines: 1032
Relevant Lines: 1574

💛 - Coveralls

Copy link
Collaborator

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykulazhenkov ykulazhenkov merged commit f9fb4e5 into Mellanox:main Aug 27, 2024
8 checks passed
@adrianchiris adrianchiris deleted the add-webhook branch January 9, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants