Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor logging change in scheduler controller #10

Merged
merged 1 commit into from
Aug 21, 2024
Merged

minor logging change in scheduler controller #10

merged 1 commit into from
Aug 21, 2024

Conversation

adrianchiris
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10441637828

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 60.611%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/controller/nodemaintenancescheduler_controller.go 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
internal/controller/nodemaintenancescheduler_controller.go 3 83.12%
Totals Coverage Status
Change from base Build 10314441297: 0.0%
Covered Lines: 714
Relevant Lines: 1178
💛 - Coveralls

ykulazhenkov
ykulazhenkov approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianchiris adrianchiris merged commit 72b91bb into Mellanox:main Aug 21, 2024
8 checks passed
@adrianchiris adrianchiris deleted the minor-sched-log-change branch January 9, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykulazhenkov ykulazhenkov ykulazhenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrianchiris @coveralls @ykulazhenkov