Cleanup and maintenance (#102)

* cleanup - remove un-needed files - rework makefile (mainly cleanup and usage of go modules and coverage) - compile plugins with coverage flags so test-coverage will work - bump go version - bump golangci-lint version and add linter config - fix lint issues in code Signed-off-by: adrianc <[email protected]> * update worflow action versions Signed-off-by: adrianc <[email protected]> * Add support for arm64 image build in workflows In addition fix image push trigger branch Signed-off-by: adrianc <[email protected]> * update packages Signed-off-by: adrianc <[email protected]> * update Dockerfile base image current base image was failing on arm64 builds. we now use debian for build and distroless for the app. Signed-off-by: adrianc <[email protected]> --------- Signed-off-by: adrianc <[email protected]>
Mellanox · Sep 10, 2024 · 5cefb59 · 5cefb59
1 parent 37fc6f4
commit 5cefb59
Show file tree

Hide file tree

Showing 36 changed files with 549 additions and 635 deletions.
diff --git a/.dockerignore b/.dockerignore
@@ -0,0 +1,4 @@
+# More info: https://docs.docker.com/engine/reference/builder/#dockerignore-file
+# Ignore build and test binaries.
+bin/
+build/
diff --git a/.github/workflows/build-images.yml b/.github/workflows/build-images.yml
@@ -9,13 +9,13 @@ jobs:
         run: echo ::set-output name=repository::$(echo ${{ github.repository }} | tr '[:upper:]' '[:lower:]')
 
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v2
+        uses: docker/setup-buildx-action@v3
 
       - name: Build container image
-        uses: docker/build-push-action@v3
+        uses: docker/build-push-action@v6
         with:
           push: false
           tags: ghcr.io/${{ steps.repo_name.outputs.repository }}:latest-amd64

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -4,15 +4,15 @@ jobs:
   build:
     strategy:
       matrix:
-        go-version: [1.19.x]
+        go-version: [1.22.x]
         goarch: [amd64]
     runs-on: ubuntu-latest
     steps:
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
           go-version: ${{ matrix.go-version }}
 

diff --git a/.github/workflows/push-main.yml b/.github/workflows/push-main.yml
diff --git a/.github/workflows/push-master.yml b/.github/workflows/push-master.yml
@@ -0,0 +1,47 @@
+name: push-master
+on:
+  push:
+    branches:
+      - master
+jobs:
+  image-build-push:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Set repository as lower-case output variable
+        id: repo_name
+        run: echo ::set-output name=repository::$(echo ${{ github.repository }} | tr '[:upper:]' '[:lower:]')
+
+      - name: Check out code into the Go module directory
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v3
+
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
+
+      - name: Docker meta
+        id: docker_meta
+        uses: docker/metadata-action@v5
+        with:
+          images: ghcr.io/${{ steps.repo_name.outputs.repository }}
+
+      - name: Login to GitHub Container Registry
+        uses: docker/login-action@v3
+        with:
+          registry: ghcr.io
+          username: ${{ github.repository_owner }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Push to GitHub Container Registry
+        uses: docker/build-push-action@v5
+        with:
+          context: .
+          push: true
+          platforms: linux/amd64,linux/arm64
+          tags: |
+            ghcr.io/${{ steps.repo_name.outputs.repository }}:latest
+          labels: ${{ steps.docker_meta.outputs.labels }}
+          file: ./Dockerfile
diff --git a/.github/workflows/push-release.yml b/.github/workflows/push-release.yml
@@ -4,84 +4,49 @@ on:
     tags:
       - v*
 jobs:
-  build-push-amd64:
-    name: Image push/amd64
+  image-build-push:
     runs-on: ubuntu-latest
     steps:
       - name: Set repository as lower-case output variable
         id: repo_name
         run: echo ::set-output name=repository::$(echo ${{ github.repository }} | tr '[:upper:]' '[:lower:]')
 
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v3
 
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v2
+        uses: docker/setup-buildx-action@v3
 
       - name: Login to GitHub Container Registry
-        uses: docker/login-action@v2
+        uses: docker/login-action@v3
         with:
           registry: ghcr.io
           username: ${{ github.repository_owner }}
           password: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Docker meta
         id: docker_meta
-        uses: docker/metadata-action@v4
+        uses: docker/metadata-action@v5
         with:
           images: ghcr.io/${{ steps.repo_name.outputs.repository }}
+          tags: |
+            type=ref,event=tag
           flavor: |
             latest=false
 
-      - name: Push container image
-        uses: docker/build-push-action@v3
+      - name: Build and Push container image
+        uses: docker/build-push-action@v5
         with:
           context: .
           push: true
+          platforms: linux/amd64,linux/arm64
           tags: |
-            ghcr.io/${{ steps.repo_name.outputs.repository }}:stable-amd64
-            ${{ steps.docker_meta.outputs.tags }}-amd64
+            ghcr.io/${{ steps.repo_name.outputs.repository }}:stable
+            ${{ steps.docker_meta.outputs.tags }}
           labels: ${{ steps.docker_meta.outputs.labels }}
           file: ./Dockerfile
-
-  create-push-manifest:
-    needs: [build-push-amd64]
-    runs-on: ubuntu-latest
-    steps:
-      - name: Set repository as lower-case output variable
-        id: repo_name
-        run: echo ::set-output name=repository::$(echo ${{ github.repository }} | tr '[:upper:]' '[:lower:]')
-
-      - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v2
-
-      - name: Docker meta
-        id: docker_meta
-        uses: docker/metadata-action@v4
-        with:
-          images: ghcr.io/${{ steps.repo_name.outputs.repository }}
-          flavor: |
-            latest=false
-
-      - name: Login to GitHub Container Registry
-        uses: docker/login-action@v2
-        with:
-          registry: ghcr.io
-          username: ${{ github.repository_owner }}
-          password: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: Create manifest for multi-arch images
-        env:
-          REPOSITORY: ghcr.io/${{ steps.repo_name.outputs.repository }}
-        run: |
-          # Get artifacts from previous steps
-          docker pull ${{ steps.docker_meta.outputs.tags }}-amd64
-          docker pull ${{ env.REPOSITORY }}:stable-amd64
-          # Create and update manifests
-          docker manifest create ${{ steps.docker_meta.outputs.tags }} ${{ steps.docker_meta.outputs.tags }}-amd64
-          docker manifest annotate ${{ steps.docker_meta.outputs.tags }} ${{ steps.docker_meta.outputs.tags }}-amd64 --arch amd64
-          docker manifest create ${{ env.REPOSITORY }}:stable ${{ env.REPOSITORY }}:stable-amd64
-          docker manifest annotate ${{ env.REPOSITORY }}:stable ${{ env.REPOSITORY }}:stable-amd64 --arch amd64
-          # push manifests
-          docker manifest push ${{ steps.docker_meta.outputs.tags }}
-          docker manifest push ${{ env.REPOSITORY }}:stable
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -4,17 +4,17 @@ jobs:
   test:
     strategy:
       matrix:
-        go-version: [1.19.x]
+        go-version: [1.22.x]
         os: [ubuntu-latest]
     runs-on: ${{ matrix.os }}
     steps:
       - name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
           go-version: ${{ matrix.go-version }}
 
       - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: lint
         run: make lint
@@ -28,18 +28,18 @@ jobs:
     needs: test
     steps:
       - name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: 1.19.x
+          go-version: 1.22.x
 
       - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Go test with coverage
         run: make test-coverage
 
       - name: Coveralls
-        uses: coverallsapp/github-action@1.1.3
+        uses: coverallsapp/github-action@v2
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
-          path-to-lcov: build/coverage/lcov.info
+          file: cover.out
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1,29 @@
+# If you prefer the allow list template instead of the deny list, see community template:
+# https://github.com/github/gitignore/blob/main/community/Golang/Go.AllowList.gitignore
+#
+# Binaries for programs and plugins
+*.exe
+*.exe~
+*.dll
+*.so
+*.dylib
+
+# Test binary, built with `go test -c`
+*.test
+
+# Output of the go coverage tool, specifically when used with LiteIDE
+*.out
+
+# Dependency directories (remove the comment below to include it)
+# vendor/
+
+# Go workspace file
+go.work
+go.work.sum
+
+# build dirs
+build/
+bin/
+
+# IDE
+.vscode