Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added brain.fm support #316

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

Conversation

josewal
Copy link

@josewal josewal commented Jun 8, 2024

I've added super crude support for brain.fm. There is no api nor embedded version. As such it may not comply with the aesthetics standart of Astrostation. Apart from that its functional and just requires user to login.

  • added to SideNav
  • added to WidgetControl
  • added brain.fm icon
  • default pos same as spotify

This is my first contribution to any open source project :)

@josewal josewal changed the base branch from main to staging June 8, 2024 22:59
@josewal
Copy link
Author

josewal commented Jun 8, 2024

You can get 30 days trial here -> https://my.brain.fm/payment?extended_promo=30&utm_source=referafriend :)

@Melkeydev
Copy link
Owner

I dont think this is going to be something we want as it requires an account.
Some users are not going to want to create an account on this, and i dont want to add login requirements for astrostation

@josewal
Copy link
Author

josewal commented Jun 9, 2024

yeah, brain.fm could be bit of a niche service. still the optional (if you want to use it) onetime login just to brainfm seems like an ok step as it remembers your authentication.

But I understand if you want to keep any login requiring widgets out.

Does that mean that the embeded spotify player requires no authentication and is a 'free spotify' player?

@Melkeydev
Copy link
Owner

yeah, brain.fm could be bit of a niche service. still the optional (if you want to use it) onetime login just to brainfm seems like an ok step as it remembers your authentication.

But I understand if you want to keep any login requiring widgets out.

Does that mean that the embeded spotify player requires no authentication and is a 'free spotify' player?

Yeah - it was initially implemented to have just enough that a user can listen freely.
But im not sure if thats still the case - or how well it even works at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants