Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video: use offline JS files #5929

Open
wants to merge 1 commit into
base: rel-1.7
Choose a base branch
from
Open

Conversation

stsrki
Copy link
Collaborator

@stsrki stsrki commented Jan 9, 2025

Closes #5928

I have followed the guide from vidstack/player#719 (comment), and I must admit it wasn't easy.

Anyhow. This PR tries to load only local files without any use of CDN originally found as part of the chunks of JS files that come with the vidstack player library. The solution wasn't as straightforward as copying files. I also had to manually fix icons and caption paths.

So far, it seems to be working, but further testing needs to be done. Also, we need to figure out how to automate this for future reference. Especially when we try to update to the latest vidstack. At the moment, we use v1.12.11.


@thumaman any chance you could test this PR on your side? It would help a lot.

@stsrki stsrki requested a review from tesar-tech January 9, 2025 12:10
@thumaman
Copy link

thumaman commented Jan 9, 2025

Yes I will try and let you know the results. Thanks

@thumaman
Copy link

thumaman commented Jan 9, 2025

In the PR that you mentioned step 11. says to put the media player directly to html. I still do not know what I have to do in order for Blazorise.Video to have the changes that I made within all the vidstack files that I downloaded so that I can use your component offline like this:
<Video @ref="mainVideo" id="mainVideo" Source="@videoSource" DefaultQuality="1080" AutoPlay="true"/>

@stsrki
Copy link
Collaborator Author

stsrki commented Jan 9, 2025

In the PR that you mentioned step 11. says to put the media player directly to html. I still do not know what I have to do in order for Blazorise.Video to have the changes that I made within all the vidstack files that I downloaded so that I can use your component offline like this: <Video @ref="mainVideo" id="mainVideo" Source="@videoSource" DefaultQuality="1080" AutoPlay="true"/>

Those steps are only for us at Blazorise. You just need to test Video component and see if everything works as expected.

@thumaman
Copy link

thumaman commented Jan 9, 2025

Are you saying I should only update my Blazorise version and test the Video component?

@stsrki
Copy link
Collaborator Author

stsrki commented Jan 9, 2025

Are you saying I should only update my Blazorise version and test the Video component?

It's not released as a NuGet. So you need to clone the repo and switch to rel-1.7-offline-video-files branch to test. Best to do it in our demo app.

@thumaman
Copy link

thumaman commented Jan 9, 2025

Got it. I will do it tomorrow and see how it goes.

@thumaman
Copy link

I have cloned the repository and moved to the branch but unfortunately i cannot get the Demo applications to work on my computer so I am unable to test the new Video component.

@stsrki
Copy link
Collaborator Author

stsrki commented Jan 10, 2025

I have cloned the repository and moved to the branch but unfortunately i cannot get the Demo applications to work on my computer so I am unable to test the new Video component.

Just a note. You need to run any of these

image

Not the Blazorise.Demo. That one is a shared razor-class-library project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants