Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Steps: change NavigationAllowed to async #5912

Merged
merged 7 commits into from
Dec 30, 2024
Merged

Steps: change NavigationAllowed to async #5912

merged 7 commits into from
Dec 30, 2024

Conversation

tesar-tech
Copy link
Collaborator

Description

Closes #4688

Description inside the proposal

@tesar-tech tesar-tech requested a review from stsrki December 23, 2024 10:44
@tesar-tech
Copy link
Collaborator Author

There is one more change that could be included in this PR:

The StepNavigationContext used as a parameter in NavigationAllowed currently has NextStepName and NextStepIndex. However, in reality, it should be something like RequestedStepName, since it’s used also when jumping between non-sequential steps (e.g., from step 1 to 4 or 4 to 1).

The current NextStep naming aligns more with its literal "next" meaning in the Steps context..

Is it worth renaming?

@stsrki stsrki changed the title Step: NavigationAllowed is async. Api changes on Steps. Steps: NavigationAllowed is async. Api changes on Steps. Dec 30, 2024
@stsrki stsrki changed the title Steps: NavigationAllowed is async. Api changes on Steps. Steps: change NavigationAllowed to async Dec 30, 2024
@stsrki stsrki merged commit 622cada into next-2.0 Dec 30, 2024
2 checks passed
@stsrki stsrki deleted the dev/next-2.0/Async-await-support-for-NavigationAllowed-in-Steps-component branch December 30, 2024 10:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stsrki stsrki stsrki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tesar-tech @stsrki