Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion: strip all usage of Collapse #5890

Merged
merged 11 commits into from
Dec 17, 2024

Conversation

tesar-tech
Copy link
Collaborator

Description

removes the "link" between Collapse and Accordion

Closes #5248

@tesar-tech tesar-tech requested a review from stsrki December 11, 2024 10:49
Copy link
Collaborator

@stsrki stsrki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise, looks good to me. I still need to run it.

Please, update 2.0 release notes and mention and migration steps needed for the upgrade.

Copy link
Collaborator

@stsrki stsrki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just update the release and migration notes.

And, update #5871 if needed so that you don't forget.

@stsrki stsrki changed the title [Next 2.0] Strip collapse from accordion Accordion: strip all usage of Collapse Dec 17, 2024
@stsrki stsrki merged commit febf259 into next-2.0 Dec 17, 2024
2 checks passed
@stsrki stsrki deleted the next-2.0-strip-collapse-from-accordion branch December 17, 2024 08:48
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants