-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluent UI v2 CSS provider #5266
Conversation
…into dev/fluentui2 # Conflicts: # Source/Blazorise.FluentUI2/wwwroot/blazorise.fluentui2.min.css
12. Fixed Can you do 11? You probably better suited since it's styling. And you're already used to the fluent styling? |
I'm eager to merge. Wanna QA fast and not tell me a thing? 🤣🤣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, most of the files I glanced over. Too many files...
|
Regarding the theme generator. Basically, this is my idea:
That is how it is done manually. We can expand from there and automate it a little. Generate a C# model from the JSON object with all of the token fields. Then, in Blazorise, the theme generator applies colors and other variables to regenerate new JSON object, and in turn, it generates CSS new variables. |
I see ok than. I guess we can improve that later. |
Closes #4135
Closes #5287
Closes #5292