Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent UI v2 CSS provider #5266

Merged
merged 265 commits into from
Feb 16, 2024
Merged

Fluent UI v2 CSS provider #5266

merged 265 commits into from
Feb 16, 2024

Conversation

stsrki
Copy link
Collaborator

@stsrki stsrki commented Jan 25, 2024

Closes #4135
Closes #5287
Closes #5292

@stsrki
Copy link
Collaborator Author

stsrki commented Feb 14, 2024

Leaving what was left to do

UI Review based on our Demo:

  1. Table Fixed Columns seems to be broken
    image

  2. Datagrid Column filters don't look too good
    image

  3. DataGrid Multiple : Clicking the checkbox does not check it
    image

@David-Moreira
Copy link
Contributor

12. Fixed

Can you do 11? You probably better suited since it's styling. And you're already used to the fluent styling?

@stsrki
Copy link
Collaborator Author

stsrki commented Feb 15, 2024

12. Fixed

Can you do 11? You probably better suited since it's styling. And you're already used to the fluent styling?

Much better, I think

image

@David-Moreira
Copy link
Contributor

12. Fixed
Can you do 11? You probably better suited since it's styling. And you're already used to the fluent styling?

Much better, I think

image

Yep, you the man!!

@stsrki
Copy link
Collaborator Author

stsrki commented Feb 15, 2024

I'm eager to merge. Wanna QA fast and not tell me a thing? 🤣🤣

@David-Moreira
Copy link
Contributor

  1. I still see no visible changes when trying to change the theme?
    image

  2. Is this the expected Modal look? Doesn't look like the header & footer are noticeably separate from the body.

image

  1. The pagination has no hover look, usually clickable / interactible items have some visual hint to them. Does fluent ui not have that? Regular buttons seem to have it.

  2. I don't see anything in the 2 pixels?

image

All in all, everything acts and looks better to me.

Copy link
Contributor

@David-Moreira David-Moreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, most of the files I glanced over. Too many files...

Demos/Blazorise.Demo.FluentUI2/dotnetwatchrun.bat Outdated Show resolved Hide resolved
Source/Blazorise.FluentUI2/Components/AlertMessage.razor Outdated Show resolved Hide resolved
@stsrki
Copy link
Collaborator Author

stsrki commented Feb 15, 2024

  1. as I have mentioned before. For now I'm not gonna do the theme generator. As an alternative, users could use Fluent design tokens, which I will document before release.
  2. Yes, this is how it looks natively. In fact it works even worse. In our version we at least have some spacings.
  3. Fixed it
  4. This works, but since Secondary color has a low contrast compared to background it is not so much visible.

@stsrki
Copy link
Collaborator Author

stsrki commented Feb 15, 2024

Regarding the theme generator. Basically, this is my idea:

image


That is how it is done manually.

We can expand from there and automate it a little. Generate a C# model from the JSON object with all of the token fields. Then, in Blazorise, the theme generator applies colors and other variables to regenerate new JSON object, and in turn, it generates CSS new variables.

@David-Moreira
Copy link
Contributor

I see ok than. I guess we can improve that later.

@stsrki stsrki merged commit c3b70ee into master Feb 16, 2024
2 checks passed
@stsrki stsrki deleted the dev/fluentui2 branch February 16, 2024 11:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rating: add tooltip for the items Update Font Awesome version to 6.x Implement Microsoft Fluent UI
2 participants