Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel | Improve previous/next slide transition responsiveness #5225

Merged

Conversation

David-Moreira
Copy link
Contributor

From my tests, this greatly improves responsiveness when switching between slides. The problem was that we were only setting the Animation to being ended after 2s. I'm not sure why we decided on that, seems like an oversight.

Notes:

@David-Moreira David-Moreira requested a review from stsrki January 13, 2024 11:53
@David-Moreira David-Moreira linked an issue Jan 13, 2024 that may be closed by this pull request
@stsrki
Copy link
Collaborator

stsrki commented Jan 13, 2024

That's a strange error for AntD, indeed.

Regarding the Bulma animation. Don't bother with it for now. Bulma is going to release v1.0 in the coming months, and hopefully, we will be part of the beta testers. So, the plan is to adjust everything for that version.

@stsrki stsrki merged commit 853620a into rel-1.4 Jan 13, 2024
2 checks passed
@stsrki stsrki deleted the 5202-bug-carousel-backnext-buttons-are-a-bit-unresponsive-1 branch January 13, 2024 13:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Carousel : Back/Next buttons are a bit unresponsive
2 participants