Scriptable value based option demo. 4am edition #5146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Eltee-Taiwo
commented
Nov 14, 2023
Eltee-Taiwo
commented
Nov 14, 2023
| @@ -52,7 +52,12 @@ function compileDatasetsOptionsCallbacks(options) { | |||
|
|
|||
| Object.keys(options).forEach(function (key) { | |||
| if (options[key] && options[key].startsWith("function")) { | |||
| options[key] = parseFunction(options[key]); | |||
| if (key === 'scriptableFormatter') { | |||
| options['formatter'] = parseFunction(options[key]); | |||
There was a problem hiding this comment.
Hacky way to make it backwards compatible and be able to keep the existing int rounding rules.
Eltee-Taiwo
commented
Nov 14, 2023
Source/Extensions/Blazorise.Charts/ScriptableValueBasedOptionsConverter.cs
Outdated
Show resolved
Hide resolved
Eltee-Taiwo
commented
Nov 14, 2023
Source/Extensions/Blazorise.Charts/ScriptableValueBasedOptions.cs
Outdated
Show resolved
Hide resolved
Eltee-Taiwo
changed the title
Eltee-Taiwo
commented
Nov 15, 2023
| @@ -182,7 +182,8 @@ public partial class ChartsDataLabelsPage | |||
| BackgroundColor = BackgroundColors[2], | |||
| BorderColor = BorderColors[2], | |||
| Align = "center", | |||
| Anchor = "center" | |||
| Anchor = "center", | |||
| SoftCodeFormatter = "function(value, context) { return \"$\" + value; }" | |||
There was a problem hiding this comment.
I tried using the scriptableOption method but using this method allows us to soft code the formatter logic and make it as complex as we want.
|
Hey, thanks for the contribution. I still need to review it properly but it seems good from what I can see. |
|
The feature is planned for 1.5. The review is still on hold as I have more ideas and changes to make it more flexible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My quickfix/workaround for being able to use a custom formatter for chart data labels.
See this discussion for more details.