Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataGridColumn | HelpText #5099

Conversation

David-Moreira
Copy link
Contributor

No description provided.

@stsrki
Copy link
Collaborator

stsrki commented Oct 23, 2023

I get this when I start the demo

image

@David-Moreira
Copy link
Contributor Author

I get this when I start the demo

image

You need to jump that exception or comment the faulty code.
It's a bug I introduced recently: #5098

@stsrki
Copy link
Collaborator

stsrki commented Oct 23, 2023

I get this when I start the demo
image

You need to jump that exception or comment the faulty code. It's a bug I introduced recently: #5098

OK please fix that in 1.3 so that we can bring it forward into the master branch.

@stsrki
Copy link
Collaborator

stsrki commented Oct 25, 2023

There are duplicates on edit form

image

image

@David-Moreira
Copy link
Contributor Author

No idea, I'll have to take a look.

@David-Moreira
Copy link
Contributor Author

There are duplicates on edit form

image

image

hmm I kinda had the logic all around. I centralized it on the _DataGridCell internal component instead. Should be good now.

@David-Moreira
Copy link
Contributor Author

@stsrki please review again

@David-Moreira
Copy link
Contributor Author

@stsrki bump

@stsrki stsrki merged commit 7935864 into master Oct 27, 2023
2 checks passed
@stsrki stsrki deleted the 4700-is-it-possible-to-define-help-text-below-the-fields-when-editing-with-a-datagrid branch October 27, 2023 19:26
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to define "help text" below the fields when editing with a datagrid?
2 participants