-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating documentation to .NET 8 - WASM mode #5091
base: rel-1.4
Are you sure you want to change the base?
Conversation
# Conflicts: # Build/Blazorise.props # Documentation/Blazorise.Docs.Server/Pages/_Layout.cshtml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean there aren't too many changes in here... Maybe because it's already on top of a branch that has net8 changes...
If it's working properly, I don't see anything of note.
I don't think our docs app warrants the need for this. It's a very simple app. As for the secrets problem, as any wasm app, they should be moved to server side if they are really sensitive, I don't think we have any, do we? Maybe we do for Blazorise Token? If we do, then that should be moved. As for the js scripts being prvented of loading, does it still happen? We are in RC so very close to release, I really doubt a fix is coming unless it was reported recently... |
Actually on second though, I've changed my mind. Since it's a simple app, it's in fact easier to deploy this, and we can have a app working on interactive auto mode, it's a way for us to have a production app on auto which allows us to have more confidence that auto is working properly. Which is expected to work properly anyway. There might be less resource usage on our server also, since people would start loading WASM instead. |
I have merged the latest 1.4, and trying to finish this PR but I get the error, see below Any chance you could help and see what might be wrong? @David-Moreira |
I don't think we will be able to overcome this. The token will still be visible on wasm mode once it is downloaded. That is something we will need to live with. That leaves us with only needing to hide secrets for sending emails. |
That seems like some kind of weird checking, can you try deleting bin, obj, you know the drill... see if it helps. |
In the new mode, wasm mode only downloads the assemblies in the client project as far as I know. So anything from a dll perspective that should be obscured should remain in the server. Although I don't remember exactly what that Blazorise Token is? I'll have to take a look later. |
Already tried deleting obj and bin folders. I figured the error happens after all wasm files are downloaded and I navigate to another page. It works only on first visit when the app still runs in interactive mode. |
@stsrki Any reason why these do not compile? EDIT: Nvm, wrong brnach... that branch name... |
@stsrki The issue should be fixed. But now you have to fix the DI for the WASM app. Let me know if you need additional help with this PR. |
This PR continues from #4998. I have separated it into a new PR so that we don't mess with the existing work.
It adds support for the new .NET 8 InteractiveAuto render mode. I'm still not sure if it's worth it. The problems that I see:
Overall, it works, but as I said, we need to consider carefully should we move forward with this mode.