Bar: working on new scss #5013
Bar: working on new scss #5013
Conversation
|
I have no clue how can I make when dropdown is open to push other elements down not to apear over them, @stsrki @David-Moreira |
I guess @stsrki might be more into this then me. From my understanding what this task entails, is to make sure we use the provider classes instead of our custom styles in order to make the vertical mode work. So that is, to work without our custom css? I would guess that replacing with the corresponding bs css classes / structure we would achieve this with minimal intervention. Is that not the case? |
|
|
@steal4life I'm sorry it seems like I completly missed this. I can't tell the difference between the this is right and this is wrong examples othen then the background being different? |
|
I managed to fix it so it is okay, thank You however @David-Moreira |
|
|
||
| public override string BarBreakpoint( Breakpoint breakpoint ) => breakpoint != Breakpoint.None && breakpoint != Breakpoint.Mobile ? $"navbar-expand-{ToBreakpoint( breakpoint )}" : null; | ||
|
|
||
| public override string BarMode( BarMode mode ) => $"b-bar-{ToBarMode( mode )}"; | ||
| public override string BarMode( BarMode mode ) => mode != Blazorise.BarMode.Horizontal ? $"navbar-{ToBarMode( mode )} flex-column" : null; |
There was a problem hiding this comment.
Not an issue, but I think it reads better in the positive mode == Blazorise.BarMode.Horizontal and invert acorrdingly.
Also that's how It is done in other places below, so I'd just keep it consistent
| public override string BarMenu( BarMode mode ) => mode == Blazorise.BarMode.Horizontal ? "collapse navbar-collapse" : "b-bar-menu"; | ||
| public override string BarMenu( BarMode mode ) => mode == Blazorise.BarMode.Horizontal ? "collapse navbar-collapse" : "collapse navbar-collapse"; |
There was a problem hiding this comment.
What's the difference here? We have a condition where both cases takes us to the same result?
There was a problem hiding this comment.
Is it expected to be collapse navbar-collapse for every case?
| public override string BarDropdown( BarMode mode, bool isBarDropDownSubmenu ) => mode == Blazorise.BarMode.Horizontal ? "dropdown" : "b-bar-dropdown"; | ||
| public override string BarDropdown( BarMode mode, bool isBarDropDownSubmenu ) => mode == Blazorise.BarMode.Horizontal ? "dropdown" : "dropdown"; | ||
|
|
| public override string BarDropdownToggle( BarMode mode, bool isBarDropDownSubmenu ) => mode == Blazorise.BarMode.Horizontal | ||
| ? isBarDropDownSubmenu | ||
| ? "dropdown-item" | ||
| : "nav-link dropdown-toggle" | ||
| : "b-bar-link b-bar-dropdown-toggle"; | ||
| : "nav-link dropdown-toggle"; |
There was a problem hiding this comment.
Please check, but this seems like it can be simplified to mode == Blazorise.BarMode.Horizontal && isBarDropDownSubmenu ...?
| public override string BarDropdownItem( BarMode mode ) => mode == Blazorise.BarMode.Horizontal ? "dropdown-item" : "b-bar-dropdown-item"; | ||
| public override string BarDropdownItem( BarMode mode ) => mode == Blazorise.BarMode.Horizontal ? "dropdown-item" : "dropdown-item"; |
| public override string BarDropdownMenu( BarMode mode ) => mode == Blazorise.BarMode.Horizontal ? "dropdown-menu" : "b-bar-dropdown-menu"; | ||
| public override string BarDropdownMenu( BarMode mode ) => mode == Blazorise.BarMode.Horizontal ? "dropdown-menu" : "dropdown-menu"; |
| public override string BarDropdownMenuRight( BarMode mode ) => mode == Blazorise.BarMode.Horizontal ? "dropdown-menu-end" : "b-bar-right"; | ||
| public override string BarDropdownMenuRight( BarMode mode ) => mode == Blazorise.BarMode.Horizontal ? "dropdown-menu-end" : "dropdown-menu-end"; |
|
for me this looks quite similar to the bootstrap bar type, now I'm working on fixing the collapsing sidebar @David-Moreira @stsrki |
closes #5007
WIP!