DatePicker: disable input on mobile #4592
Conversation
|
It will probably confuse users when the form is greyed out as if it is disabled but is enabled just that the keyboard wont show up. |
|
I have to agree with Mr.Pearce, If I'm a user I would think its disabled by some reason. |
| @@ -52,7 +52,7 @@ export function initialize(element, elementId, options) { | |||
| clickOpens: !(options.readOnly || false), | |||
| disable: options.disabledDates || [], | |||
| inline: options.inline || false, | |||
| disableMobile: options.disableMobile || true, | |||
| disableMobile: options.disableMobile || false, | |||
There was a problem hiding this comment.
maybe I'm dumb, what is this? options.disableMobile || false? is this some kind of way to coalesce?
| allowInput: !(options.disableMobile || false), | ||
| altInput: !(options.disableMobile || false), |
There was a problem hiding this comment.
Is this some kind of way to coalesce is that it? I don't get the usage of the or logic here.
| allowInput: !(isMobile() && (options.disableMobile || false)), | ||
| altInput: !(isMobile() && (options.disableMobile || false)), |
There was a problem hiding this comment.
My mind can't think today :D Is this right? Does it handle every case?
Might be a better read if you just bring the isMobile() out.
I.E
!IsMobile() || (isMobile() && !options.disableMobile)
But I think it's those pipes that are killing me, again is it a coalesce operation?
There was a problem hiding this comment.
The logic is actually broken on flatpickr side. They don't detect the mobile device properly. So I was trying to come up with a workaround, even pushed a PR on their repo, but it still seems not to detect all of the mobile devices.
|
@stsrki friendly reminder, this PR sitting here |
I know. I still didn't have much time to fix an error on flatpickr side. Which we must do before even applying it here. |
|
Just a friendly reminder, @stsrki |
|
Friendly reminder, What is the status of this one? |
Unfortunately, it seems that flat pick is not actively maintained. So, in the long run, we need to either fork it or maintain it ourselves. Or move to another library. |
FYI @stsrki : Maybe more stuff is broken with flatpick. |
Might be something with the js interop. Can you open new issue and make a reproducible? |
Closes #4577
This PR disables the input it DisableMobile is enabled. I have also set DisableMobile with default
false, par flatpickr documentation.The only problem is that the input is shown as grayed like it has a disabled state. I don't know if that is the right behavior for the flatpickr.
Example
@Mr-Pearce do you think this is OK?