-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: PivotGrid #3214
base: master
Are you sure you want to change the base?
WIP: PivotGrid #3214
Conversation
<PivotGridValue Caption="Quantity"></PivotGridValue> | ||
<PivotGridValue Caption="Amount"></PivotGridValue> | ||
</PivotGridValues> | ||
<PivotGridRows> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the use-case for rows? Why do we need to define them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand now what you wanted to do. It has an API similar to the SF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the same uses cases as this API
enum Area {
Row, // it will be shown in a row header and grouped by this => PivotGridRow
Column, // it will be shown as a regular column, just like DataGrid => PivotGridColumn
Data, // it will be used for the summary => PivotGridValue
}
Pivot columns should be defined the same as for the enum Area {
Row, // it will be shown in a row header and grouped by this
Column, // it will be shown as a regular column, just like DataGrid
Data, // it will be used for the summary
} when enum SummaryType {
Sum,
Count,
// etc.
} |
I personally prefer to explicitly define components Didn't I Already introduce the SummaryType.. Can be named GroupType or AggregateType? Summary seems weird? Is that Pivot terminology? I haven't worked on this for some time, I just redid the stuff now on master to keep up with the branch easily. |
I realized later that you used components for the same thing that I wanted to have with parameters. It is OK to proceed that way. My only concern is that it will have an API that is different from our DataGrid. |
Hmm what about this API, would this be closer while still maintaing the component approach?
Or do you feel Blazorise users would be more inclined to use |
I guess we should start from scratch with PivotGrid? |
Yea just because of the conflicts. From reading the comments it seems we couldn't decide on a surface api yet, you had different thoughts then me. |
No description provided.