Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Strip all logic that uses Collapse within the Accordion #5248

Closed
stsrki opened this issue Jan 20, 2024 · 2 comments
Closed

[2.0] Strip all logic that uses Collapse within the Accordion #5248

stsrki opened this issue Jan 20, 2024 · 2 comments
Assignees
Labels
Type: Feature ⚙ Request or idea for a new feature.
Milestone

Comments

@stsrki
Copy link
Collaborator

stsrki commented Jan 20, 2024

Reason

Using the Collapse within accordion is leaking too much of logic between components that are not that directly connected. Since we have added dedicated AccordionItem, AccordionHeader, and AccordionBody there is no need for using Collapse in the Accordion anymore.

@stsrki stsrki added the Type: Feature ⚙ Request or idea for a new feature. label Jan 20, 2024
@stsrki stsrki added this to the 2.0 milestone Jan 20, 2024
@tesar-tech
Copy link
Collaborator

So this means removing the Collapse component from the codebase entirely, right?

It seems there is no other usage for it apart from being part of the Accordion, which will no longer be the case in 2.0.

Or what's the reason for keeping Collapse component?

@stsrki
Copy link
Collaborator Author

stsrki commented Dec 7, 2024

We want to leave Collapse component.It still has it's use cases.

But any usage WITHIN the accordion needs to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature ⚙ Request or idea for a new feature.
Projects
Status: Done
Development

No branches or pull requests

2 participants