fix: addresses bug #5663 where the financeTable is empty (has zero ro… #5666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zero rows) resulting in array out of bounds exception
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5666 +/- ##
============================================
- Coverage 10.02% 10.02% -0.01%
- Complexity 6067 6068 +1
============================================
Files 1074 1074
Lines 141598 141671 +73
Branches 20645 20653 +8
============================================
+ Hits 14201 14204 +3
- Misses 126024 126096 +72
+ Partials 1373 1371 -2 ☔ View full report in Codecov by Sentry. |
IllianiCBT
approved these changes
Jan 6, 2025
HammerGS
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ws) resulting in array out of bounds exception
Addresses #5663
Sorry about that, I think this should fix it. At least it did in my minimal testing.