feat: utf-8 for i18n, new report for start of scenario on acar, player name, misc #5622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acar, fix for formation values and player name on acar
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -35,5 +36,9 @@ | |||
| getSimulationManager().calculatePlayerInitialCounts(); | |||
| getSimulationManager().getGame().setupTeams(); | |||
| getSimulationManager().getGame().setupDeployment(); | |||
|
|
|||
| var reporter = new StartingScenarioPhaseReporter(getSimulationManager().getGame(), getSimulationManager()::addReport); | |||
Check notice
Code scanning / CodeQL
Unread local variable Note
| } | ||
| } | ||
|
|
||
| private void playerFinalReport(Player player) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
Comment on lines
+71
to
+75
| var playerEntities = game.getInGameObjects().stream() | ||
| .filter(e -> e.getOwnerId() == player.getId()) | ||
| .filter(Entity.class::isInstance) | ||
| .map(Entity.class::cast) | ||
| .toList(); |
Check notice
Code scanning / CodeQL
Unread local variable Note
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5622 +/- ##
============================================
- Coverage 10.04% 10.02% -0.02%
+ Complexity 6073 6066 -7
============================================
Files 1074 1075 +1
Lines 141557 141644 +87
Branches 20639 20650 +11
============================================
- Hits 14215 14202 -13
- Misses 125974 126069 +95
- Partials 1368 1373 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
self.