Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh menu bar to new current unit when new tab is selected #1684

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

pavelbraginskiy
Copy link
Member

You can't switch unit type to the unit type of the current unit, but if the menu bar isn't refreshed, it'll use the unit type of the first unit, not the current unit, to determine which unit kind you can't switch to.

Refreshing the menu bar when you switch to a new tab solves this (and likely some other problems as well).

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.13%. Comparing base (b4ceda1) to head (5875756).
Report is 16 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1684      +/-   ##
===========================================
- Coverage      2.13%   2.13%   -0.01%     
  Complexity      209     209              
===========================================
  Files           270     271       +1     
  Lines         31350   31368      +18     
  Branches       5337    5339       +2     
===========================================
  Hits            670     670              
- Misses        30523   30541      +18     
  Partials        157     157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sleet01 Sleet01 self-requested a review January 6, 2025 02:40
Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pavelbraginskiy pavelbraginskiy merged commit 0b0cd43 into MegaMek:master Jan 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants