-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Add color-flow support (GE proposal) #140
Draft
forderud
wants to merge
5
commits into
MedicalUltrasound:master
Choose a base branch
from
forderud:cf-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forderud
force-pushed
the
cf-support
branch
2 times, most recently
from
November 11, 2019 08:11
568ce30
to
abedcd1
Compare
forderud
force-pushed
the
cf-support
branch
7 times, most recently
from
February 20, 2020 10:22
6b0ec2b
to
1014e90
Compare
forderud
force-pushed
the
cf-support
branch
16 times, most recently
from
March 23, 2020 08:59
8ba6b0c
to
e7a3c14
Compare
forderud
force-pushed
the
cf-support
branch
18 times, most recently
from
March 23, 2020 13:18
2478c03
to
df246fd
Compare
Also, prefix enum values with "IMAGE_" to make room for a separate enum for color-map types.
Specify type when calling GetColorMap.
…low data Extend the API to also support display of color-flow data, in addition to tissue. This is intended to be a simple representation that is compatible with the way color-flow data is processed by any vendor. Please note that the color-flow appearance is unlikely to exactly match the appearance on the original system, since the "internal" vendor encoding and algorithms are likely to be more advanced. The goal is therefore to get visual appearance that is fairly close to the original. Integration of this extension will probably require bidirectional code for converting between the "internal" vendor encoding and the Image3dAPI encoding of flow data. Only an API update so far. Actual color-flow support will be added in a later PR.
The important part here is the TestViewer GenerateBitmap function, which serves as a reference implementation of color-flow display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to extend the API to also support display of color-flow data, in addition to tissue. This is intended to be a simple representation that is compatible with the way color-flow data is processed by any vendor.
Please note that the color-flow appearance is unlikely to exactly match the appearance on the original system, since the "internal" vendor encoding and algorithms are likely to be more advanced. The goal is therefore to get visual appearance that is fairly close to the original.
Integration of this extension will probably require bidirectional code for converting between the "internal" vendor encoding and the Image3dAPI encoding of flow data.
Changes:
IImage3dStream
interface for grouping together "tissue" vs. "flow" framesTissue/flow display algorithm:
An implementation of this is found in the TestViewer
GenerateBitmap
function.Screenshot