Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Return empty EcgSeries if EGC is not available #136

Merged
merged 1 commit into from
Aug 5, 2019
Merged

DOC: Return empty EcgSeries if EGC is not available #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Image3dAPI/IImage3d.idl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ interface IImage3dSource : IUnknown {
[helpstring("Retrieve color-map table for mapping image intensities to RGBx values. Length is 256.")]
HRESULT GetColorMap ([out,retval] SAFEARRAY(unsigned int) * map);

[helpstring("Get ECG data if available [optional]")]
[helpstring("Get ECG data if available [optional]. Shall return S_OK with an empty EcgSeries if EGC is not available.")]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EcgSeries could meaningfully be used to transfer only trig points, without ECG trace. DICOM files typically only contain the R-wave times, not the trace values. EcgSeries samples could also benefit from a document update to highlight this.

In addition, it may be cases where a loader returns trig points where some intervals contain no frames. This could be the case for multi-cycle acquisitions, where the full volume is composed of data acquired over multiple cycles. It would then be expected behavior for a loader to return trig intervals without frames. A client that displays QRS/trig points and/or trace could then benefit from trimming the displayed data. The documentation could be updated to highlight this.

HRESULT GetECG ([out,retval] EcgSeries * ecg);

[helpstring("")]
Expand Down