show upload progress per file in interactive mode #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a little surprised this pull request has been lingering for so long with no comment, no merge. Patch looks clean, simple, and useful. The indentation of the new "if" block is different than the rest of the file. |
|
@jleclanche you feel like merging this? It's your call. |
|
Ah sorry, I didn't see it. Code lgtm, I'll test it and if it works I'll merge. |
|
Iirc there were complaints about the progress bar not getting hidden when it's done. Also speed stats would be cool (which could be achieved by not using --progress-bar and just removing --silent) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calls curl with --progress-bar and without --silent for file uploads in interactive mode. I find this quite useful for files that have more than 2-3MB on DSL internet.