Skip to content

Commit

Permalink
Internal. Stabilize tests
Browse files Browse the repository at this point in the history
ShellProcessor takes into account detected bitness, which is mocked as
32bit
  • Loading branch information
Maximus5 committed Apr 17, 2022
1 parent ab8b563 commit bf24287
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/ConEmuHk/ShellProcessor_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -218,12 +218,12 @@ TEST_F(ShellProcessor, Far300)
{Function::CreateW,
nullptr, LR"(""C:\1 @\a.cmd"")",
nullptr,
LR"("%ConEmuBaseDirTest%\)" ConEmuC_EXE_3264 R"(" %ConEmuLogTest%/PARENTFARPID=%ConEmuTestPid% /C ""C:\1 @\a.cmd"")"},
LR"("%ConEmuBaseDirTest%\)" ConEmuC_32_EXE R"(" %ConEmuLogTest%/PARENTFARPID=%ConEmuTestPid% /C ""C:\1 @\a.cmd"")"},

{Function::CreateW,
LR"(C:\1 @\a.cmd)", nullptr, // important to have two double quotes, otherwise cmd will strip one and fail to find the file
nullptr,
LR"("%ConEmuBaseDirTest%\)" ConEmuC_EXE_3264 R"(" %ConEmuLogTest%/PARENTFARPID=%ConEmuTestPid% /C ""C:\1 @\a.cmd"")"},
LR"("%ConEmuBaseDirTest%\)" ConEmuC_32_EXE R"(" %ConEmuLogTest%/PARENTFARPID=%ConEmuTestPid% /C ""C:\1 @\a.cmd"")"},

// #TODO: Add DosBox mock/test
{Function::CreateW,
Expand Down Expand Up @@ -300,7 +300,7 @@ TEST_F(ShellProcessor, Far175)
{Function::CreateA,
nullptr, R"(""C:\1 @\a.cmd"")",
nullptr,
R"("%ConEmuBaseDirTest%\)" WIN3264TEST("ConEmuC.exe", "ConEmuC64.exe") R"(" %ConEmuLogTest%/PARENTFARPID=%ConEmuTestPid% /C ""C:\1 @\a.cmd"")"},
R"("%ConEmuBaseDirTest%\)" "ConEmuC.exe" R"(" %ConEmuLogTest%/PARENTFARPID=%ConEmuTestPid% /C ""C:\1 @\a.cmd"")"},
{Function::CreateA,
nullptr, R"(C:\Windows\system32\cmd.exe /K ""C:\1 @\a.cmd"")",
nullptr,
Expand Down
2 changes: 2 additions & 0 deletions src/common/ConEmuCheck.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,8 @@ BOOL LoadSrvMapping(HWND hConWnd, CESERVER_CONSOLE_MAPPING_HDR& SrvMapping)
const CESERVER_CONSOLE_MAPPING_HDR* pInfo = SrvInfoMapping.Open();
if (!pInfo || pInfo->nProtocolVersion != CESERVER_REQ_VER)
{
_ASSERTEX(pInfo != nullptr);
_ASSERTEX(pInfo != nullptr && pInfo->nProtocolVersion == CESERVER_REQ_VER);
return false;
}

Expand Down

0 comments on commit bf24287

Please sign in to comment.