Improve performance #156
Open
Improve performance #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👏👏👏👏👏 |
arnaudcourtecuisse
force-pushed
the
contrib
branch
from
0515d7d to
19d3259
Compare
|
Resolved conflict ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I profile TLE execution and noticed that it spent a lot of time in
isValidLoc.Thus I modified the
GridMapclass to avoid these checks.It relies on optional chaining, which is not supported in webpack 4, so I bumped it.
I also shipped a couple of tweaks that made my life easier while developing.
Let me know if you want me to remove them.