Updates $is_mobile() #156
Open
Updates $is_mobile() #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 2, 2014 10:32
I have changed the `is_mobile()` function so that it returns a boolean.
function is_mobile() {
$userAgent = strtolower($_SERVER['HTTP_USER_AGENT']);
return !!strpos($userAgent, 'mobile');
}
This renders this if/else block unnecessary:
if(!is_mobile()){
$is_mobile = "FALSE";
} else {
$is_mobile = "TRUE";
}
I have removed this and replaced it with `$is_mobile = is_mobile();`.
I have also removed the same if else block from within the `sendErrorImage()` function, but I have **not** replaced it as the variable was unused within its scope.
It's worth pointing out that the `$is_mobile` variable is only used once in the entire script. It might be a better idea to remove the function all together, and just use `$is_mobile = !!strpos(strtolower($_SERVER['HTTP_USER_AGENT']);`. I haven't made this change as there may be need for this helper function in the future.
|
is this repo dead? @MattWilcox |
|
It's pretty inactive but there are signs of life every once in awhile. Maybe it's time to fork it, or check out some of the other forks. Or maybe Matt will add some maintainers to help out? On Mon, Oct 27, 2014 at 9:09 AM, Billy Mathews [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the
is_mobile()function so that it returns a boolean.This renders this if/else block unnecessary:
I have removed all occurrences of this and replaced it with
$is_mobile = is_mobile();.