Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action to build and run template project on all 3 OS #241

Conversation

drbergman
Copy link
Collaborator

tests added for building and running the template project in all 3 OSs

NB: this is the first time I've made a github action. hopefully this is useful!

@elmbeech
Copy link
Contributor

elmbeech commented Jun 4, 2024

Nice! Thank you, Daniel!

I yesterday looked into the subject too.
GitHub actions are great, but I think this is not really scalable.
We should combine GitHub action with an actual test framework.

I read up on test frameworks in my C++ book ( https://nostarch.com/cppcrashcourse ).
There are 3 test frameworks mentioned (although many more exist):

Personally, I think Catch2 would be the way to go. C++11 is support is in v2.x branch.
It is popular, people say it is easy to write tests, it is lightweight, and I think will be scalable enough.

@vincent-noel
Copy link
Collaborator

vincent-noel commented Jun 4, 2024

Agree with @elmbeech, the "tests" we have now are just compile and run a few projects, without any checks, and should ultimately be replaced by proper tests.
Still, they are useful and we should already use them more. Maybe even add some basic check of the results.

I have an idea how to code an action to make it very easy to add new projects, I'll give it a try and maybe submit a PR if I can make it work.

@elmbeech
Copy link
Contributor

elmbeech commented Jun 4, 2024

@drbergman
Copy link
Collaborator Author

superseded by #242

@drbergman drbergman closed this Jun 5, 2024
@drbergman drbergman deleted the feature-template-project-test branch August 16, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants