Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3 async #103

Merged
merged 21 commits into from
Nov 7, 2021
Merged

3 async #103

merged 21 commits into from
Nov 7, 2021

Conversation

Chakipaki
Copy link
Contributor

Without sort and filter
This 1st version

@Chakipaki
Copy link
Contributor Author

Chakipaki commented Nov 5, 2021 •
edited
Loading

Add sort, delete post options, loading 3 sec

@electrovladyslav electrovladyslav self-assigned this Nov 5, 2021
@electrovladyslav
Copy link
Contributor

Это бы сильно облегчило мою работу

Також було б класно якби всі налаштували собі в репозиторіях GitHub Pages (з наступної домашки то буде обовʼязково) https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#choosing-a-publishing-source
Потрібно включити це в сетінгах та відкрити по потрібній вам url

@Chakipaki
Copy link
Contributor Author

https://chakipaki.github.io/home3-async/

electrovladyslav
electrovladyslav requested changes Nov 5, 2021
View reviewed changes
homeworks/ivan.bieliaiev_Ckakipaki/3-async/app.js Outdated Show resolved Hide resolved
homeworks/ivan.bieliaiev_Ckakipaki/3-async/app.js Outdated Show resolved Hide resolved
homeworks/ivan.bieliaiev_Ckakipaki/3-async/app.js Outdated Show resolved Hide resolved
homeworks/ivan.bieliaiev_Ckakipaki/3-async/app.js Outdated Show resolved Hide resolved
homeworks/ivan.bieliaiev_Ckakipaki/3-async/app.js Outdated Show resolved Hide resolved
homeworks/ivan.bieliaiev_Ckakipaki/3-async/index.html Outdated Show resolved Hide resolved
homeworks/ivan.bieliaiev_Ckakipaki/3-async/index.html Outdated Show resolved Hide resolved
homeworks/ivan.bieliaiev_Ckakipaki/3-async/app.js Outdated Show resolved Hide resolved
homeworks/ivan.bieliaiev_Ckakipaki/3-async/app.js Outdated Show resolved Hide resolved
@Chakipaki
Copy link
Contributor Author

https://chakipaki.github.io/home3-async/

@electrovladyslav
Copy link
Contributor

Всё ещё сломана совместная работа фильтров и сортировки #103 (comment)

@Bieliash
upg
5fbd999
@Bieliash
Fixed some problem
0ccb561 
I don't know how to connect sort and filter togther(I try it, but I can't resolve this problem)
@Chakipaki Chakipaki closed this Nov 5, 2021
@Chakipaki Chakipaki reopened this Nov 5, 2021
@Bieliash
END
d1cdcf6 
I can’t resolve all problem, waiting for you check))
@Chakipaki
Copy link
Contributor Author

https://chakipaki.github.io/home3-async/

@Chakipaki
Copy link
Contributor Author

https://chakipaki.github.io/home3-async/
Maybe final commit))

@electrovladyslav electrovladyslav merged commit 29cee1f into MastersAcademy:main Nov 7, 2021
@electrovladyslav
Copy link
Contributor

Молодец!

@Chakipaki
Copy link
Contributor Author

Chakipaki commented Nov 7, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrovladyslav electrovladyslav electrovladyslav approved these changes

Assignees

@electrovladyslav electrovladyslav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chakipaki @electrovladyslav @Bieliash