Skip to content

Commit

Permalink
disable name mangling in production for now
Browse files Browse the repository at this point in the history
since source-mapping doesn't seem to produce correct line numbers, obfuscated names make error reports even harder to read
  • Loading branch information
TanninOne committed Jun 5, 2018
1 parent 419a10c commit 41534bb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 19 deletions.
2 changes: 1 addition & 1 deletion webpack.main.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ module.exports = {
sourceMap: true,
uglifyOptions: {
compress: true,
mangle: true,
mangle: false,
keep_fnames: true, // required atm, name mangling breaks extensions
}
})
Expand Down
20 changes: 2 additions & 18 deletions webpack.renderer.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,28 +43,12 @@ module.exports = {
sourceMap: true,
uglifyOptions: {
compress: true,
mangle: true,
mangle: false,
keep_fnames: true, // required atm, name mangling breaks extensions
}
})
]
},
devtool: 'source-map',
externals: /*Object.assign(externals(), {
'bindings': 'bindings',
'crash-dump': 'crash-dump',
'drivelist': 'drivelist',
'edge': 'edge',
'i18next-node-fs-backend': 'i18next-node-fs-backend',
'icon-extract': 'icon-extract',
'leveldown': 'leveldown',
'node-sass': 'node-sass',
'turbowalk': 'turbowalk',
'vortex-run': 'vortex-run',
'ws': 'ws',
}),*/
/*
externals: ['crash-dump', 'drivelist', 'edge', 'exe-version', 'express', 'ffi', 'i18next-node-fs-backend',
'icon-extract', 'leveldown', 'nbind', 'node-sass', 'permission', 'ref', 'semver', 'turbowalk',
'vortex-parse-ini', 'vortex-run', 'winston', 'ws'],*/ nodeExternals(),
externals: nodeExternals(),
};

0 comments on commit 41534bb

Please sign in to comment.