feat: add job manager conventions #68
Conversation
razbroc
commented
Jun 20, 2024
razbroc
commented
| Question | Answer |
|---|---|
| Bug fix | ✖ |
| New feature | ✔ |
| Breaking change | ✖ |
| Deprecations | ✖ |
| Documentation | ✖ |
| Tests added | ✖ |
| Chore | ✔ |
|
Hi it is me, your friendly bot helper! 👋 {
"dependencies": {
"@map-colonies/telemetry": "https://ghatmpstorage.blob.core.windows.net/npm-packages/telemetry-8377f018804d710854ce299ee147f2fe47a37b5a.tgz"
}
}The link will expire in a week ⌛ |
razbroc
requested review from
asafMasa
and removed request for
CptSchnitz and
shimoncohen
| "deprecated": false, | ||
| "description": "Array of tasks (uuid array)" | ||
| }, | ||
| "status": { |
There was a problem hiding this comment.
Hmmmm, I believe it might be better to be just "status" since it appears as "status" in DB, and can be used for tasks and jobs.
Should I note it in the description?
There was a problem hiding this comment.
even if its like this in the DB, it might be confusing with other statuses across mapcolonies
src/semanticConventions/infra.json
Outdated
| "status": { | ||
| "propertyName": "mapcolonies.infra.job_management.status", | ||
| "deprecated": false, | ||
| "description": "Status of job as stored on db (COMPLETED/ IN-PROGRESS/ PENDING)" |
There was a problem hiding this comment.
(COMPLETED/ IN-PROGRESS/ PENDING, etc.)
|
Hi it is me, your friendly bot helper! 👋 {
"dependencies": {
"@map-colonies/telemetry": "https://ghatmpstorage.blob.core.windows.net/npm-packages/telemetry-d4efd12154e5fd933febfb84a3735bb86ba150e5.tgz"
}
}The link will expire in a week ⌛ |
|
Hi it is me, your friendly bot helper! 👋 {
"dependencies": {
"@map-colonies/telemetry": "https://ghatmpstorage.blob.core.windows.net/npm-packages/telemetry-6a73558c6e4adcc4a40abf4dc66de7a2b7f6768d.tgz"
}
}The link will expire in a week ⌛ |
| "status": { | ||
| "propertyName": "mapcolonies.infra.job_management.status", | ||
| "deprecated": false, | ||
| "description": "Status of job/task as stored on db (COMPLETED/ IN-PROGRESS/ PENDING, etc.)" |
There was a problem hiding this comment.
| "description": "Status of job/task as stored on db (COMPLETED/ IN-PROGRESS/ PENDING, etc.)" | |
| "description": "Status of job/task as stored on db (COMPLETED, IN-PROGRESS, PENDING, etc.)" |
| @@ -16,7 +16,7 @@ | |||
| "jobId": { | |||
| "propertyName": "mapcolonies.infra.job_management.job_id", | |||
| "deprecated": false, | |||
| "description": "Type of task as stored on db (uuid)" | |||
| "description": "Type of job as stored on db (uuid)" | |||
There was a problem hiding this comment.
This is not a type but an ID. Please change description accordingly.
This comment is relevant for taskId, jobType, and taskType's desriptions as well.
| "taskIds": { | ||
| "propertyName": "mapcolonies.infra.job_management.task_ids", | ||
| "deprecated": false, | ||
| "description": "Array of tasks (uuid array)" |
There was a problem hiding this comment.
| "description": "Array of tasks (uuid array)" | |
| "description": "Array of task ids (uuid array)" |
