Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump deps to v0.9.18 #481

Merged
merged 32 commits into from
Jun 3, 2022
Merged

Bump deps to v0.9.18 #481

merged 32 commits into from
Jun 3, 2022

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented Apr 11, 2022 •
edited
Loading

Signed-off-by: Dengjianping [email protected]

Description

v0.9.16 -> v0.9.17

Polkadot:

Substrate:

Cumulus:

v0.9.17 -> v0.9.18

Polkadot:

Substrate:

Cumulus:

ORML:

Ours:

  • Type, ParentIsDefault -> ParentIsPreset
  • Cli tool, Replace structopt with clap
  • New extrinsic to asset-manager: set_min_xcm_fee.
  • codec from 2.0 to 3.0
  • scale-info from 1.0 to 2.0
  • pallet_collective::EnsureProportionAtLeast<_3, _4, AccountId, CouncilCollective>
    ->
    pallet_collective::EnsureProportionAtLeast<AccountId, CouncilCollective, 3, 4>
  • Re-benchmark calamari-runtime.
  • Improve xcm tests.

closes: #497
closes: #456

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Added one line describing your change in <branch>/CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics
  • If import a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are offcially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inhreited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@Dengjianping
Bump deps to v0.9.18
1d5ac8e 
Signed-off-by: Dengjianping <[email protected]>
@bhgomes bhgomes marked this pull request as ready for review April 13, 2022 02:24
@Dengjianping
Fix compilation
11b728b 
Signed-off-by: Dengjianping <[email protected]>
ghzlatarev
ghzlatarev reviewed Apr 13, 2022
View reviewed changes
pallets/asset-manager/src/lib.rs Outdated Show resolved Hide resolved
runtime/dolphin/src/tests/mod.rs Outdated Show resolved Hide resolved
@Dengjianping Dengjianping mentioned this pull request Apr 14, 2022
Merged
10 tasks
@Dengjianping
Merge pull request #488 from Manta-Network/jamie/extend-assets-manager
efba175 
Extend asset-manager for adapting to xtokens
stechu
stechu requested changes Apr 16, 2022
View reviewed changes
Copy link
Collaborator

@stechu stechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. need to test the actual usage of min_xcm_fee in asset_manager.
  2. see the detailed comments

@stechu
Copy link
Collaborator

stechu commented Apr 16, 2022

Also a meta question, why we are duplicating code in dolphin and calamari for parachain xcm tests?

@ghzlatarev
Copy link
Contributor

Also a meta question, why we are duplicating code in dolphin and calamari for parachain xcm tests?

Not really needed, the only difference is NativeAssetMetadata . I'll open a PR to dedupe this.

@Dengjianping Dengjianping added this to the v3.1.6 milestone Apr 18, 2022
@Dengjianping Dengjianping self-assigned this Apr 18, 2022
@ghzlatarev
Copy link
Contributor

This is an important update because of paritytech/cumulus#896 . This will allow us to disable incoming messages from xcmp queues.

@stechu stechu marked this pull request as draft May 4, 2022 15:42
@Dengjianping Dengjianping marked this pull request as ready for review May 9, 2022 10:41
ghzlatarev
ghzlatarev previously approved these changes May 9, 2022
View reviewed changes
@ghzlatarev
Copy link
Contributor

@Dengjianping I think you can close #497 with this PR

@Dengjianping
Merge brach manta
bbd656f 
Signed-off-by: Dengjianping <[email protected]>
@Dengjianping
Make asset location like (1, X2(para_id, _) and reserve chain locatio…
a452caf 
…n like (1, X1(para_id)) in xcm fee test case

Signed-off-by: Dengjianping <[email protected]>
@Dengjianping
[no ci]Improve comments
5e5a6aa 
Signed-off-by: Dengjianping <[email protected]>
stechu
stechu requested changes May 27, 2022
View reviewed changes
pallets/asset-manager/src/lib.rs Outdated Show resolved Hide resolved
ghzlatarev
ghzlatarev previously approved these changes May 30, 2022
View reviewed changes
stechu
stechu previously approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@stechu stechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my minor comment. Also please fix @ghzlatarev 's comments. The code looks super nice now!

pallets/asset-manager/src/lib.rs Outdated Show resolved Hide resolved
@bhgomes bhgomes dismissed stale reviews from stechu and ghzlatarev via a46c3d9 June 2, 2022 02:10
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Please signoff on all commits with your name, email and gpg key for the Developer's Certificate of Origin.
git config --global user.name your_name
git config --global user.email you_email
COMMAND : git commit -s -S -m your_commit_message
-s = Signed-off-by
-S = Verify commit using gpg key
If there is more than one commit in your pull request and your git client is modern enough (2.13+), rebase the required number of commits with --signoff:
git rebase --signoff HEAD~<number_of_commits>
Then, force push:
git push -f origin <your_branch>
For instructions on managing gpg signature verification please visit: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@bhgomes
chore: update method names
9148200 
Signed-off-by: Brandon H. Gomes <[email protected]>
@bhgomes bhgomes mentioned this pull request Jun 3, 2022
Merged
@ghzlatarev ghzlatarev requested review from stechu and removed request for ghzlatarev June 3, 2022 06:26
@stechu stechu merged commit b4ab435 into manta Jun 3, 2022
@stechu stechu deleted the jamie/v0.9.18 branch June 3, 2022 20:53
@Dengjianping Dengjianping mentioned this pull request Jun 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghzlatarev ghzlatarev ghzlatarev approved these changes

@stechu stechu stechu approved these changes

@Garandor Garandor Awaiting requested review from Garandor

Assignees

@Dengjianping Dengjianping

Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

Dedupe mock XCM tests Update to Parity dependencies to v0.9.18
4 participants
@Dengjianping @stechu @ghzlatarev @bhgomes