Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add From<Box<T>> where T: ?Sized #94

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sokra
Copy link

@sokra sokra commented Aug 7, 2024

adds an unstable features which allows to convert a Box<T> with unsized T into an Arc<T>

Comment on lines +16 to +20
- name: Install Rust ${{ matrix.rust }}
uses: actions-rs/toolchain@v1
with:
toolchain: ${{ matrix.rust }}
override: true
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without that the matrix value was just ignored and it was always running on stable

@sokra sokra marked this pull request as ready for review August 7, 2024 07:31
@Manishearth
Copy link
Owner

Not really a fan of adding an unstable feature to this repo unless it's something majorly useful. Happy to leave this PR open for whenever the metadata feature stabilizes.

@sokra
Copy link
Author

sokra commented Aug 9, 2024

it's something majorly useful.

Otherwise I can't convert my Box<dyn Any> into an Arc<dyn Any>...

But I can fallback to using my branch until it stabilizes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants