Make HeaderSliceWithLen… always contain slices
#110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the access; also remove additional conversion step from Drop for ThinArc
|
(PR autoclosed because I deleted the branch, remake against master) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the
ptr:field ofThinArcback to be a non-…Protectedtype. And that's good, because it used[T; 0]so the invariantes used to be deliberately broken.After this, I also looked through all uses of
ptrand reworked a few of them (for instance, many of them directly passed the pointer tothin_to_thick; which is now part ofthin_to_thickitself.This PR currently targets the PR branch of #108 directly, so feel free to fast-forward merge if it should become part of #108, or let me re-target
masterif this should become a follow-up PR.