Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seprate HeaderSliceWithLength into checked and unchecked variants #108

Merged
merged 6 commits into from
Dec 31, 2024
+163 −40
Merged

Seprate HeaderSliceWithLength into checked and unchecked variants #108

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b65f34
Seprate HeaderSliceWithLength into checked and unchecked variants
Manishearth Dec 25, 2024
197193f
rm alias
Manishearth Dec 25, 2024
5de1d9f
fixes
Manishearth Dec 25, 2024
3f421fd
protected
Manishearth Dec 25, 2024
d2febb4
Handle replacing
Manishearth Dec 25, 2024
c823d7c
guard
Manishearth Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/thin_arc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,11 @@ impl<H, T> ThinArc<H, T> {

// Expose the transient Arc to the callback, which may clone it if it wants
// and forward the result to the user
f(&mut transient)
let ret = f(&mut transient);
// It is possible for the user to replace the Arc entirely here. If so, we need to update the ThinArc as well
// Safety: We're still in the realm of Protected types so this cast is safe
self.ptr = transient.p.cast();
Manishearth marked this conversation as resolved.
Show resolved Hide resolved
ret
}

/// Creates a `ThinArc` for a HeaderSlice using the given header struct and
Expand Down
Loading