Gemfile supports ruby 3.3 #23204
Merged
Gemfile supports ruby 3.3 #23204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
failure is the wrong version of get_fasttexxt fixed with: #23205 |
|
This pull request is not mergeable. Please rebase and repush. |
kbrock
force-pushed
the
test_with_ruby
branch
from
1db2bd9 to
2129ca5
Compare
|
update:
|
kbrock
force-pushed
the
test_with_ruby
branch
2 times, most recently
from
21f47bf to
ad7d36a
Compare
|
@miq-bot cross-repo-tests /all |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Sep 27, 2024
From Pull Request: ManageIQ/manageiq#23204
Fryguy
reviewed
Sep 27, 2024
Fryguy
approved these changes
Sep 27, 2024
testing with ruby 3.3 These changes allow other repos to run with ruby 3.3
kbrock
force-pushed
the
test_with_ruby
branch
from
ad7d36a to
0bb23f1
Compare
|
Checked commit kbrock@0bb23f1 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
|
update:
update:
Thinking kicking off cross-repo tests is not necessary with this change |
agrare
approved these changes
Sep 27, 2024
jrafanie
approved these changes
Sep 27, 2024
Let's see how rough testing 4 rubies will be on core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows tests to run with ruby3.3
Other non core repos were complaining when bringing in this Gemfile.