Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading ruby to 3.3 #23142

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Upgrading ruby to 3.3 #23142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ jobs:
strategy:
matrix:
ruby-version:
- '3.0'
- '3.1'
- '3.2'
- '3.3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbrock Even if we jump from 3.1 to 3.3 in a release, we should include 3.2 with 3.3 so if they fail in CI, we can determine if it's a problem unique to 3.3 or also a problem in 3.2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, since we will never use 3.2, I'm mixed on this one.
Already got 2 thumbs up, so I'll add it.
But it seems a waste of cycles and unnecessary granularity

test-suite:
- vmdb
Expand Down
6 changes: 2 additions & 4 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
raise "Ruby versions < 3.0.1 are unsupported!" if RUBY_VERSION < "3.0.1"
warn "Ruby versions >= 3.2.0 are untested!" if RUBY_VERSION >= "3.2.0"
raise "Ruby versions >= 3.4.0 are unsupported!" if RUBY_VERSION >= "3.4.0"

ruby ">= 3.1.1", "< 3.5.0"
warn "Ruby versions >= 3.4.0 are untested!" if RUBY_VERSION >= "3.4.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this resolve the issue around rubocop and warning for testing of untested rubies?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. adding the padding on the top ( < 3.5 instead of < 3.4) with the warning in there will help us in the future too.

source 'https://rubygems.org'

plugin "bundler-inject", "~> 2.0"
Expand Down