Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [_dark.scss] Use less harsh color for light logos #1018

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NickLaMuro
Copy link
Member

@NickLaMuro NickLaMuro commented Sep 17, 2021

This gives less of a stark contrast when viewing /logos with the Dark theme, as it isn't as harsh as the default white is.

Before

Screen Shot 2021-09-17 at 6 35 14 PM

After

Screen Shot 2021-09-17 at 6 34 56 PM

This gives less of a stark contrast when viewing /logos with the Dark
theme, as it isn't as harsh as the default white is.
@Fryguy
Copy link
Member

Fryguy commented Sep 21, 2021

I'm not sure I like the light blue - it's actually pulsing my eyes unfortunately.

@NickLaMuro
Copy link
Member Author

@Fryguy Up to you. This was a relatively easy one to throw together, and I don't mind if we don't merge.

I just was trying to think of a way to make the logo page "dark like" while still having a light background for the logos that mostly require it. I would argue it is "less pulsing" than the white there previously, but I am honestly not sold on it myself.

Feel free to close, I won't mind. 🙂

@Fryguy
Copy link
Member

Fryguy commented Sep 21, 2021

Would a grey / off-white work?

@NickLaMuro
Copy link
Member Author

Would a grey / off-white work?

I can try some things later and see.


Again, this was just something I thought of prior to starting on the SVG stuff and going down that rabbit hole, so I didn't want to mix the two since I figured this might have some opinions with it.

Since there might be something worth looking into, I can mess with it later, but mark it [WIP] for now. 👍

@NickLaMuro NickLaMuro changed the title [_dark.scss] Use light blue for light logos [WIP] [_dark.scss] Use less harsh color for light logos Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants