-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add terraform catalog entry point selection #9223
base: master
Are you sure you want to change the base?
[WIP] Add terraform catalog entry point selection #9223
Conversation
I think the entry points should be in the base Information tab, but i could be persuaded. That being said, Retirement definitely does not belong in the Provisioning tab. |
Should be fixed now, moved both to the basic information tab. |
id: 'provisioning_entry_point_automate', | ||
name: 'provisioning_entry_point_automate', | ||
label: __('Provisioning Entry Point'), | ||
initialValue: '/Service/Generic/StateMachines/GenericLifecycle/provision', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This initial value is different for different types, and should come from the backend (either that or we need to expose over API or something)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember since its been a while that I've looked at this but I believe @agrare said we don't need an API for this because we can use the default entry point data from here
https://github.com/ManageIQ/manageiq-providers-embedded_terraform/blob/9bd72922e221d4d78f211f8e061c20e216059bca/app/models/service_template_terraform_template.rb.
e7e5b7d
to
92c8bfe
Compare
d13742f
to
9cafbc4
Compare
4626d33
to
84ba56c
Compare
Checked commits GilbertCherrie/manageiq-ui-classic@1c90dbc~...16a7760 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Embedded Workflow select:
Embedded Repository select: