Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add terraform catalog entry point selection #9223

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

GilbertCherrie
Copy link
Member

@GilbertCherrie GilbertCherrie commented Jul 12, 2024

Embedded Workflow select:
Screenshot 2024-07-15 at 9 40 31 AM

Embedded Repository select:
Screenshot 2024-07-15 at 9 40 05 AM

@GilbertCherrie GilbertCherrie requested a review from a team as a code owner July 12, 2024 17:37
@GilbertCherrie GilbertCherrie requested a review from Fryguy July 12, 2024 17:37
@GilbertCherrie GilbertCherrie requested a review from agrare July 12, 2024 17:37
@miq-bot miq-bot added the wip label Jul 12, 2024
@Fryguy
Copy link
Member

Fryguy commented Jul 12, 2024

I think the entry points should be in the base Information tab, but i could be persuaded. That being said, Retirement definitely does not belong in the Provisioning tab.

@GilbertCherrie
Copy link
Member Author

I think the entry points should be in the base Information tab, but i could be persuaded. That being said, Retirement definitely does not belong in the Provisioning tab.

Should be fixed now, moved both to the basic information tab.

id: 'provisioning_entry_point_automate',
name: 'provisioning_entry_point_automate',
label: __('Provisioning Entry Point'),
initialValue: '/Service/Generic/StateMachines/GenericLifecycle/provision',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This initial value is different for different types, and should come from the backend (either that or we need to expose over API or something)

Copy link
Member Author

@GilbertCherrie GilbertCherrie Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember since its been a while that I've looked at this but I believe @agrare said we don't need an API for this because we can use the default entry point data from here
https://github.com/ManageIQ/manageiq-providers-embedded_terraform/blob/9bd72922e221d4d78f211f8e061c20e216059bca/app/models/service_template_terraform_template.rb.

@GilbertCherrie GilbertCherrie force-pushed the add_terraform_catalog_entry_point_selection branch from e7e5b7d to 92c8bfe Compare October 31, 2024 20:35
@GilbertCherrie GilbertCherrie force-pushed the add_terraform_catalog_entry_point_selection branch from d13742f to 9cafbc4 Compare November 13, 2024 14:23
@Fryguy Fryguy assigned kbrock and unassigned Fryguy Nov 15, 2024
@GilbertCherrie GilbertCherrie force-pushed the add_terraform_catalog_entry_point_selection branch from 4626d33 to 84ba56c Compare December 5, 2024 19:27
@miq-bot
Copy link
Member

miq-bot commented Dec 5, 2024

Checked commits GilbertCherrie/manageiq-ui-classic@1c90dbc~...16a7760 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants