Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payload validity attributes to configuration_scripts #710

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Add payload validity attributes to configuration_scripts #710

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
def35ca
Add payload validity to configuration_scripts
agrare Nov 8, 2023
bf65b56
Default to payload_valid=t
agrare Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions db/migrate/20231108172936_add_valid_to_configuration_scripts.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
class AddValidToConfigurationScripts < ActiveRecord::Migration[6.1]
def change
add_column :configuration_scripts, :payload_valid, :boolean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set a default of true (or in Ruby use default_value_for)? Reason I'm asking is that ansible playbooks will be seen as "nil" valid, which is falsey in Ruby, so .payload_valid? will return false.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 will do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

add_column :configuration_scripts, :payload_error, :string
end
end