Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix route permissions issues after #989 #996

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Sep 28, 2023

routes:
E0928 15:56:00.508746 1 reflector.go:147] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch *v1.Route: failed to list *v1.Route: routes.route.openshift.io is forbidden: User "system:serviceaccount:petrosian-1:manageiq-operator" cannot list resource "routes" in API group "route.openshift.io" in the namespace "petrosian-1"
W0928 15:56:44.778213 1 reflector.go:535] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: failed to list *v1.Route: routes.route.openshift.io is forbidden: User "system:serviceaccount:petrosian-1:manageiq-operator" cannot list resource "routes" in API group "route.openshift.io" in the namespace "petrosian-1"

routes/custom-host:
2023-09-28T16:30:38Z ERROR Reconciler error {"controller": "manageiq", "controllerGroup": "manageiq.org", "controllerKind": "ManageIQ", "ManageIQ": {"name":"manageiq-sample","namespace":"petrosian-1"}, "namespace": "petrosian-1", "name": "manageiq-sample", "reconcileID": "78aec8d7-f66d-4d63-8203-60f031384f19", "error": "Route.route.openshift.io "httpd" is invalid: spec.host: Forbidden: you do not have permission to set the host field of the route"}

routes:
E0928 15:56:00.508746       1 reflector.go:147] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch *v1.Route: failed to list *v1.Route: routes.route.openshift.io is forbidden: User "system:serviceaccount:petrosian-1:manageiq-operator" cannot list resource "routes" in API group "route.openshift.io" in the namespace "petrosian-1"
W0928 15:56:44.778213       1 reflector.go:535] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: failed to list *v1.Route: routes.route.openshift.io is forbidden: User "system:serviceaccount:petrosian-1:manageiq-operator" cannot list resource "routes" in API group "route.openshift.io" in the namespace "petrosian-1"

routes/custom-host:
2023-09-28T16:30:38Z	ERROR	Reconciler error	{"controller": "manageiq", "controllerGroup": "manageiq.org", "controllerKind": "ManageIQ", "ManageIQ": {"name":"manageiq-sample","namespace":"petrosian-1"}, "namespace": "petrosian-1", "name": "manageiq-sample", "reconcileID": "78aec8d7-f66d-4d63-8203-60f031384f19", "error": "Route.route.openshift.io \"httpd\" is invalid: spec.host: Forbidden: you do not have permission to set the host field of the route"}
@miq-bot
Copy link
Member

miq-bot commented Sep 28, 2023

Checked commit bdunne@3d874af with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@bdunne bdunne changed the title Fix route permissions issues after #989 [wip] Fix route permissions issues after #989 Sep 28, 2023
@miq-bot miq-bot added the wip label Sep 28, 2023
@Fryguy Fryguy self-assigned this Sep 29, 2023
@Fryguy
Copy link
Member

Fryguy commented Sep 29, 2023

@bdunne Does this need to go back to petrosian?

@bdunne bdunne changed the title [wip] Fix route permissions issues after #989 Fix route permissions issues after #989 Sep 29, 2023
@miq-bot miq-bot removed the wip label Sep 29, 2023
@Fryguy Fryguy merged commit 7f24767 into ManageIQ:master Sep 29, 2023
3 checks passed
@bdunne bdunne deleted the route_permissions branch September 29, 2023 13:41
@Fryguy
Copy link
Member

Fryguy commented Sep 29, 2023

Backported to quinteros in commit 61553a3.

commit 61553a39260c3182f2e9169a17f82f27328b7b14
Author: Jason Frey <[email protected]>
Date:   Fri Sep 29 09:41:18 2023 -0400

    Merge pull request #996 from bdunne/route_permissions
    
    Fix route permissions issues after #989
    
    (cherry picked from commit 7f247673f5d87f9bc532f3f5b2a09e4b64c6aacb)

Fryguy added a commit that referenced this pull request Sep 29, 2023
Fix route permissions issues after #989

(cherry picked from commit 7f24767)
@bdunne
Copy link
Member Author

bdunne commented Sep 29, 2023

@bdunne Does this need to go back to petrosian?

No, #989 only went back to quinteros

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants