Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RBAC for the automation worker #995

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Sep 26, 2023

@Fryguy
Copy link
Member

Fryguy commented Sep 26, 2023

@bdunne Sorry - we should have been clearer. The new worker is the "AutomationWorker" and is not workflow specific. In the future we plan to use this worker for any automation that requires running an external job and watching it (so think Ansible, Terraform, etc).

So, I think the Workflow naming here (in particular the role names) needs to change to automate or automation.

@miq-bot
Copy link
Member

miq-bot commented Sep 26, 2023

Checked commit bdunne@47a2d33 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@Fryguy Fryguy self-assigned this Sep 26, 2023
@bdunne bdunne changed the title Add RBAC for the workflow worker Add RBAC for the automation worker Sep 26, 2023
@Fryguy Fryguy merged commit b34c2f4 into ManageIQ:master Sep 27, 2023
3 checks passed
@Fryguy
Copy link
Member

Fryguy commented Sep 27, 2023

Backported to quinteros in commit 16f7116.

commit 16f7116388278046116756f0ac8429053567a25f
Author: Jason Frey <[email protected]>
Date:   Wed Sep 27 11:11:53 2023 -0400

    Merge pull request #995 from bdunne/workflows_rbac
    
    Add RBAC for the automation worker
    
    (cherry picked from commit b34c2f4372b997532fcbde38ad93a9d25f909c8a)

Fryguy added a commit that referenced this pull request Sep 27, 2023
Add RBAC for the automation worker

(cherry picked from commit b34c2f4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants