go get -t -u ./... && go mod tidy #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bdunne
commented
Sep 26, 2023
bdunne
commented
- Upgrade to sigs.k8s.io/[email protected]
- Upgrade to sigs.k8s.io/[email protected]
|
Checked commit bdunne@03be4ff with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
Fryguy
reviewed
Sep 26, 2023
| "sigs.k8s.io/controller-runtime/pkg/healthz" | ||
| logf "sigs.k8s.io/controller-runtime/pkg/log" | ||
| "sigs.k8s.io/controller-runtime/pkg/log/zap" | ||
| ctrlmetrics "sigs.k8s.io/controller-runtime/pkg/metrics/server" |
There was a problem hiding this comment.
Not that it really matter, but I would expect this to be next to the other new one sort of alphabetically?
There was a problem hiding this comment.
Yeah, me too. Unfortunately the tooling keeps moving it down there 🤦🏻♂️
Fryguy
reviewed
Sep 26, 2023
Comment on lines
-74
to
-77
|
|
||
| replace github.com/gogo/protobuf v1.3.1 => github.com/gogo/protobuf v1.3.2 // Fix CVE-2021-3121 | ||
|
|
||
| replace k8s.io/client-go v0.27.4 => k8s.io/client-go v0.28.0-rc.0 // https://github.com/kubernetes/client-go/issues/1265 |
Fryguy
approved these changes
Sep 26, 2023
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Sep 27, 2023
go get -t -u ./... && go mod tidy (cherry picked from commit 8be17ba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.