Avoid installing weak dependencies #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
force-pushed
the
weak_deps
branch
3 times, most recently
from
d583813 to
78024d7
Compare
Fryguy
changed the title
The following weak dependencies will end up not being installed. ``` apr-util-bdb apr-util-openssl geolite2-city geolite2-country libmaxminddb perl-Digest perl-Digest-MD5 perl-IO-Socket-IP perl-IO-Socket-SSL perl-libnet perl-Mozilla-CA perl-Net-SSLeay perl-URI python38-pip python3-jmespath rubygem-bundler rubygem-json rubygem-rdoc ``` This drops the image size roughly from 2.063GB to 1.943GB (120MB, 5.85%). Of note, the geolite2 packages are somewhat large, so part of ManageIQ#736
|
Checked commit Fryguy@2590c5e with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint |
bdunne
reviewed
Jul 11, 2022
| @@ -45,7 +45,7 @@ COPY container-assets/clean_dnf_rpm /usr/local/bin/ | |||
|
|
|||
| RUN curl -L https://releases.ansible.com/ansible-runner/ansible-runner.el8.repo > /etc/yum.repos.d/ansible-runner.repo | |||
|
|
|||
| RUN dnf -y --disableplugin=subscription-manager --setopt=tsflags=nodocs install \ | |||
| RUN dnf -y --disableplugin=subscription-manager --setopt=tsflags=nodocs --setopt=install_weak_deps=False install \ | |||
There was a problem hiding this comment.
Suggested change
| RUN dnf -y --disableplugin=subscription-manager --setopt=tsflags=nodocs --setopt=install_weak_deps=False install \ | |
| RUN dnf config-manager --setopt=tsflags=nodocs --setopt=install_weak_deps=False --save && \ | |
| dnf -y --disableplugin=subscription-manager install \ |
Then we can drop those settings from all following commands.
There was a problem hiding this comment.
Not sure if we want to put subscription-manager in there too
There was a problem hiding this comment.
I was gonna ask if you wanted to do that - do we want that for this PR or a followup ?
I was thinking of doing that as a followup and in the base image right at the beginning
There was a problem hiding this comment.
Not sure if we want to put subscription-manager in there too
Unfortunately, we still need subscription-manager for the s390x builds.
Fryguy
added a commit
to Fryguy/manageiq-appliance-build
that referenced
this pull request
Sep 28, 2022
Similar change to ManageIQ/manageiq-pods#846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
The following weak dependencies will end up not being installed.
This drops the image size roughly from 2.063GB to 1.943GB (120MB, 5.85%). Of note, the geolite2 packages are somewhat large, so part of #736
Packages sizes sorted by size: