-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix reload! for MiqAeMethodService #445
Conversation
Pull Request Test Coverage Report for Build 4123
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Requesting further explanation'.
after reload classes don't exist. and that includes what we were delegating for the class missing before: ``` > reload! Traceback (most recent call last): 16: from activesupport (5.2.4.3) lib/active_support/dependencies.rb:510:in `load_missing_constant' 15: from activesupport (5.2.4.3) lib/active_support/dependencies.rb:356:in `require_or_load' 14: from activesupport (5.2.4.3) lib/active_support/dependencies.rb:37:in `load_interlock' 13: from activesupport (5.2.4.3) lib/active_support/dependencies/interlock.rb:13:in `loading' 12: from activesupport (5.2.4.3) lib/active_support/concurrency/share_lock.rb:151:in `exclusive' 11: from activesupport (5.2.4.3) lib/active_support/dependencies/interlock.rb:14:in `block in loading' 10: from activesupport (5.2.4.3) lib/active_support/dependencies.rb:37:in `block in load_interlock' 9: from activesupport (5.2.4.3) lib/active_support/dependencies.rb:373:in `block in require_or_load' 8: from activesupport (5.2.4.3) lib/active_support/dependencies.rb:475:in `load_file' 7: from activesupport (5.2.4.3) lib/active_support/dependencies.rb:661:in `new_constants_in' 6: from activesupport (5.2.4.3) lib/active_support/dependencies.rb:476:in `block in load_file' 5: from activesupport (5.2.4.3) lib/active_support/dependencies.rb:476:in `load' 4: from lib/miq_automation_engine/engine/miq_ae_method_service/miq_ae_service_model_base.rb:3:in `<top (required)>' 3: from lib/miq_automation_engine/engine/miq_ae_method_service/miq_ae_service_model_base.rb:4:in `<module:MiqAeMethodService>' 2: from lib/miq_automation_engine/engine/miq_ae_method_service/miq_ae_service_model_base.rb:13:in `<class:MiqAeServiceModelBase>' 1: from lib/miq_automation_engine/engine/miq_ae_method_service.rb:12:in `const_missing' NoMethodError (undefined method `create_service_model_from_name' for MiqAeMethodService::MiqAeServiceModelBase:Class) ``` after: ``` > reload! sure thing. coming right up > ```
fix reload! (cherry picked from commit f44fae6)
Jansa backport details:
|
FYI, this is a slippery slope. I've been here. Dev reload of automation engine doesn't work. #418. I had a similar change in that issue but couldn't get dev reload to work at all in many situations, specifically: #418 (comment) I'm curious which problem this fixes because I think there's lots more buried in automation engine due to file paths not being autoloadable, etc. |
There was a weird class load issue. Just wanted to fix it. |
after reload classes don't exist. and that includes what we were
delegating for the class missing
before:
after: