[WIP] Remove to_xml

[d-m-u]

This is follow-up to #429.

This was what I could remove without specs failing, and it's kinda late, so I'll get back to it tomorrow.

there are a few more:

lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_object.rb:193:    def attribute_value_to_xml(value, xml)
lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_object.rb:204:            xml.Element(:index => i + 1) { attribute_value_to_xml(value[i], xml) }
lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_object.rb:210:            xml.Key(:name => k.to_s) { attribute_value_to_xml(v, xml) }
lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_object.rb:221:    def to_xml(options = {})
lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_object.rb:227:          xml.MiqAeAttribute(:name => k) { attribute_value_to_xml(@attributes[k], xml) }
lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_object.rb:230:        children.each { |c| c.to_xml(:builder => xml) }
lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_workspace_runtime.rb:201:        objs.each { |obj| obj.to_xml(:builder => xml) }
lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_workspace_runtime.rb:205:    def to_xml(path = nil)
lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_workspace_runtime.rb:209:      XmlHash.from_hash({"MiqAeObject" => result}, {:rootname => "MiqAeWorkspace"}).to_xml.write(s, 2)

but with those removed as well,

manageiq-automation_engine/spec/miq_ae_state_machine_spec.rb

Line 37 in 1a3ba3a

expect(ws.root['ae_result']).to eq('ok')

fails with ae_result of error rather than ok.

Maybe also app/models/miq_ae_datastore/xml_import.rb can go, but I have to look closer at it tomorrow cause it causes uninitialized constant constant problems

[d-m-u]

@miq-bot add_label technical debt

[coveralls]

Pull Request Test Coverage Report for Build 4367

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.5%) to 86.232%

---

Files with Coverage Reduction	New Missed Lines	%
lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_builtin_method.rb	1	52.6%
lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_workspace_runtime.rb	1	86.4%

Totals
Change from base Build 4366:	0.5%
Covered Lines:	4973
Relevant Lines:	5767

---

💛 - Coveralls

[gmcculloug]

@mkanoor Any concern with trying to get rid of all the XML stuff on master? It likely needs to happen over the course of a few PRs, but feels like a good technical debt cleanup. Thoughts?

[mkanoor]

@gmcculloug I think the UI uses this to display the output of simulation, we would have to coordinate with them to start using JSON instead of XML when displaying the simulation output.
https://github.com/ManageIQ/manageiq-ui-classic/blob/b0e5666b3d3abfa857856c4bae70759039f84c6c/app/presenters/tree_builder_automate_simulation_results.rb#L17
There might be other places in the UI. Otherwise looks good

[skateman]

The Automate->Simulation in the UI depends on the to_xml method as the simulation results can be displayed as XML and the tree view is being built by parsing the same XML. I can try to build the tree directly from the result object, but it doesn't really help if we don't get rid of the XML view.

[gmcculloug]

@skateman I see little use for the XML View tab so I feel it is safe to remove. @mkanoor Do we have the methods to support building the Tree View from YAML or JSON?

[skateman]

@gmcculloug we don't really need the YAML or JSON version, I can just build the tree directly from the objects. Faster to build directly and avoid parsing of formats...

[d-m-u]

there's also to_expanded_xml which I'm not sure if I can remove or not because we use it in miq_log_workspace(obj, _inputs) inside miq_ae_builtin_method

[skateman]

That's the one I'm dependent on in the UI, but it's getting close...

[d-m-u]

gotcha, thanks

[skateman]

I'm blocked by #418 but @jrafanie is working on it

[d-m-u]

it's fine, this's got that failing spec that i'm looking into, there's no rush

[skateman]

Orienting in the code is way too complicated for me, so maybe @mkanoor's idea about you implementing a to_json version isn't that bad...if you can.

[lfu]

How about xml_import? Do we not remove it this time?

[djberg96]

@skateman, @lfu is the baked in Rails method something we could use?

https://apidock.com/rails/Hash/to_xml

[miq-bot]

Checked commit d-m-u@9a57516 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
5 files checked, 0 offenses detected
Everything looks fine. 👍

[d-m-u]

I don't think we can make this change without an implementation of to_json.