Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[WIPTEST] Added fixture to validate repo url from yaml #9917

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ganeshhubale
Copy link
Member

@ganeshhubale ganeshhubale commented Feb 12, 2020

Signed-off-by: Ganesh Hubale [email protected]

Purpose or Intent

  • Enhanced test cases in test_git_import.py by adding fixture to validate git repo url from cfme_data.yml file
  • As per this comment
  • Updated skip message too.

PRT Run

{{ pytest: cfme/tests/automate/test_git_import.py -k 'test_automate_git_domain_removed_from_disk or test_automate_git_domain_displayed_in_service or test_automate_git_import_multiple_domains or test_domain_import_git or test_domain_import_git_rest or test_automate_git_import_case_insensitive or test_automate_git_domain_import_connection or test_automate_git_import_without_master or test_git_refresh_with_renamed_yaml' -vvv }}

@dajoRH
Copy link
Contributor

dajoRH commented Feb 12, 2020

I detected some fixture changes in commit ad253517aa6eb4811023d4a41b9939aba35253b0

The local fixture git_repo_url is used in the following files:

  • cfme/tests/automate/test_git_import.py
    • imported_domain
    • test_automate_git_domain_removed_from_disk
    • test_automate_git_domain_displayed_in_service
    • test_automate_git_import_multiple_domains
    • test_domain_import_git
    • test_domain_import_git_rest
    • test_automate_git_import_case_insensitive
    • test_automate_git_domain_import_connection
    • test_automate_git_import_without_master
    • test_git_refresh_with_renamed_yaml

The local fixture imported_domain is used in the following files:

  • cfme/tests/automate/test_git_import.py
    • test_automate_git_domain_removed_from_disk
    • test_refresh_git_current_user
    • test_automate_git_verify_ssl
    • test_automate_git_import_deleted_tag

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@ganeshhubale ganeshhubale force-pushed the repo_url_fixture branch 4 times, most recently from 2649345 to 26accb1 Compare February 19, 2020 15:14
@ganeshhubale ganeshhubale changed the title [WIPTEST] Added fixture to validate repo url from yaml [RFR] Added fixture to validate repo url from yaml Feb 20, 2020
@ganeshhubale ganeshhubale force-pushed the repo_url_fixture branch 2 times, most recently from 88be821 to 3cf0d13 Compare February 24, 2020 09:24
@ganeshhubale ganeshhubale force-pushed the repo_url_fixture branch 2 times, most recently from 83c7e61 to 2faebc4 Compare February 24, 2020 11:42
@@ -494,7 +494,7 @@ def step(self, *args, **kwargs):
except CandidateNotFound:
# Try it with regexp (drop the locked to None)
# That will force reload from database
self.obj.locked = None
delattr(self.obj, "locked")
Copy link
Contributor

@jarovo jarovo Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required: I don't think there is a reason for use of delattr when we can use del

Suggested change
delattr(self.obj, "locked")
del self.obj.locked

This may help with code analysis in some code editors and re-factoring tools.

@john-dupuy john-dupuy changed the title [RFR] Added fixture to validate repo url from yaml [WIPTEST] Added fixture to validate repo url from yaml Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants