This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 165
[WIPTEST] Added fixture to validate repo url from yaml #9917
Open
ganeshhubale
wants to merge
1
commit into
ManageIQ:master
Choose a base branch
from
ganeshhubale:repo_url_fixture
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I detected some fixture changes in commit ad253517aa6eb4811023d4a41b9939aba35253b0 The local fixture
The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
ganeshhubale
force-pushed
the
repo_url_fixture
branch
4 times, most recently
from
February 19, 2020 15:14
2649345
to
26accb1
Compare
ganeshhubale
changed the title
[WIPTEST] Added fixture to validate repo url from yaml
[RFR] Added fixture to validate repo url from yaml
Feb 20, 2020
ganeshhubale
force-pushed
the
repo_url_fixture
branch
2 times, most recently
from
February 24, 2020 09:24
88be821
to
3cf0d13
Compare
ganeshhubale
force-pushed
the
repo_url_fixture
branch
2 times, most recently
from
February 24, 2020 11:42
83c7e61
to
2faebc4
Compare
jarovo
suggested changes
Feb 24, 2020
cfme/automate/explorer/domain.py
Outdated
@@ -494,7 +494,7 @@ def step(self, *args, **kwargs): | |||
except CandidateNotFound: | |||
# Try it with regexp (drop the locked to None) | |||
# That will force reload from database | |||
self.obj.locked = None | |||
delattr(self.obj, "locked") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required: I don't think there is a reason for use of delattr when we can use del
Suggested change
delattr(self.obj, "locked") | |
del self.obj.locked |
This may help with code analysis in some code editors and re-factoring tools.
john-dupuy
changed the title
[RFR] Added fixture to validate repo url from yaml
[WIPTEST] Added fixture to validate repo url from yaml
Feb 26, 2020
Signed-off-by: Ganesh Hubale <[email protected]>
ganeshhubale
force-pushed
the
repo_url_fixture
branch
from
March 23, 2020 06:09
2faebc4
to
fe405a2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ganesh Hubale [email protected]
Purpose or Intent
test_git_import.py
by adding fixture to validategit repo url
fromcfme_data.yml
filePRT Run
{{ pytest: cfme/tests/automate/test_git_import.py -k 'test_automate_git_domain_removed_from_disk or test_automate_git_domain_displayed_in_service or test_automate_git_import_multiple_domains or test_domain_import_git or test_domain_import_git_rest or test_automate_git_import_case_insensitive or test_automate_git_domain_import_connection or test_automate_git_import_without_master or test_git_refresh_with_renamed_yaml' -vvv }}