Fix: define CLTCPServer as uncopyable

MakingL · Jan 9, 2020 · 6ac34f7 · 6ac34f7
1 parent 2d17bfe
commit 6ac34f7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/tcp.cpp b/src/tcp.cpp
@@ -11,7 +11,9 @@
 
 static std::string g_local_ip;
 
-CLTCPServer::CLTCPServer(const char *host, unsigned int port) : m_port(port), m_host(host) {
+CLTCPServer::CLTCPServer(const char *host, unsigned int port) : m_port(port),
+                                                                m_host(host),
+                                                                m_listen_fd(0) {
     if ((m_listen_fd = socket(PF_INET, SOCK_STREAM, 0)) < 0) {
         utility::unix_error("Cannot create socket");
     }

diff --git a/src/tcp.h b/src/tcp.h
@@ -19,6 +19,11 @@ class CLTCPServer {
 
     }
 
+    ~CLTCPServer() {
+        if (m_listen_fd) {
+            close(m_listen_fd);
+        }
+    }
 
     int start_listen();
 
@@ -27,6 +32,11 @@ class CLTCPServer {
     bool limit_client_crowding(int connect_fd, unsigned int client_ip); /* 限流*/
     void on_a_client_exit(unsigned int client_ip);
 
+private:
+    /* 禁止复制 CLTCPServer 对象。只声明 copying 函数，不定义 */
+    CLTCPServer(const CLTCPServer&);
+    CLTCPServer &operator=(const CLTCPServer &);
+
 private:
     unsigned int m_port;
     std::string m_host;